Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enterprise-edge extension #5191

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Aug 3, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@StrawnSC
Copy link
Contributor Author

StrawnSC commented Aug 3, 2022

@yonzhan we've already moved all of these commands to the core CLI and would like to prevent future customers from installing the enterprise-edge extension. I'm assuming that we can do that by removing the source from this repo and removing enterprise-edge entry from the index.json. Is that correct?

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 3, 2022

@kairu-ms @zhoxing-ms @jsntcy for awareness

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 4, 2022

@StrawnSC Yes, the source code can be removed directly.
But if the az extension add -n enterprise-edge command is used in some users' scripts to install this extension, remove index.json may cause breaking change to them, so it is recommended to remove index.json during the breaking change window of CLI (Build Event and Ignite Event)
For more details about CLI breaking change process, please refer to this doc breaking_changes.md

@StrawnSC StrawnSC marked this pull request as ready for review October 8, 2022 07:53
@StrawnSC
Copy link
Contributor Author

@zhoxing-ms are we good to merge + release this?

@zhoxing-ms zhoxing-ms closed this Oct 14, 2022
@zhoxing-ms zhoxing-ms reopened this Oct 14, 2022
@wangzelin007 wangzelin007 reopened this Oct 14, 2022
@yonzhan yonzhan merged commit 1284512 into Azure:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants