Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aks [nodepool] update without args prompts to reconcile. #4759

Merged
merged 13 commits into from
May 5, 2022

Conversation

paulgmiller
Copy link
Member

@paulgmiller paulgmiller commented May 1, 2022


This is an alternateive to #4719 aks is debating.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 May 1, 2022 23:14
@ghost ghost assigned zhoxing-ms May 1, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone May 1, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 1, 2022
@ghost ghost requested a review from yonzhan May 1, 2022 23:14
@ghost ghost added the AKS label May 1, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 2, 2022

AKS

@paulgmiller paulgmiller marked this pull request as ready for review May 2, 2022 18:32
src/aks-preview/azext_aks_preview/_help.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/_help.py Outdated Show resolved Hide resolved
'"--disable-cluster-autoscaler" or '
'"--update-cluster-autoscaler" or '
'"--tags" or "--mode" or "--max-surge" or "--scale-down-mode" or "--labels" or "--node-taints')
reconcilePrompt = "no argument specified to update would you like to reconcile to current settings?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Use ' rather than " for consistency, since from what I can tell that's the style used elsewhere in this file.

paulgmiller and others added 3 commits May 4, 2022 14:49
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
@paulgmiller
Copy link
Member Author

@FumingZhang I think we're good on the aks side so looking for your review at this point.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang
Copy link
Member

In addition, the CI failure is due to a test case that is not related to this PR. Will fix it in another PR.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 5, 2022

Do you need to add a new version for this extension to release these changes? If so, please also modify the HISTORY.rst and setup.py files

@paulgmiller
Copy link
Member Author

paulgmiller commented May 5, 2022

Do you need to add a new version for this extension to release these changes? If so, please also modify the HISTORY.rst and setup.py files

I'm not sure what the pattern is here do we bump the version on every change or batch several of them?

Bumped version and HISTORY.md but not actually what is normal here.

In addition, the CI failure is due to a test case that is not related to this PR. Will fix it in another PR.

Is there a way to rerun tests?

@zhoxing-ms
Copy link
Contributor

I'm not sure what the pattern is here do we bump the version on every change or batch several of them?
Bumped version and HISTORY.md but not actually what is normal here.

@paulgmiller It mainly depends on whether you want these features to be released immediately in a new extension version?
Please note that if you do not upgrade the extension version, these codes will only be merged to extension repo, but will not be released for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants