[Spring Cloud] Add service registry related commands for Enterprise #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninpan-ms
force-pushed
the
ninpan/service-registry
branch
from
9fdae4f
to
00ae939
Compare
|
Spring Cloud |
|
|
||
| def only_support_enterprise(cmd, namespace): | ||
| if namespace.resource_group and namespace.service and not is_enterprise_tier(cmd, namespace.resource_group, namespace.service): | ||
| raise CLIError("'{}' only supports for Enterprise tier Spring instance.".format(namespace.command)) |
There was a problem hiding this comment.
Could you please use a specific error type instead of CLIError ?
|
|
||
| def not_support_enterprise(cmd, namespace): | ||
| if namespace.resource_group and namespace.service and is_enterprise_tier(cmd, namespace.resource_group, namespace.service): | ||
| raise CLIError("'{}' doesn't support for Enterprise tier Spring instance.".format(namespace.command)) |
wangzelin007
approved these changes
Dec 28, 2021
ninpan-ms
force-pushed
the
ninpan/service-registry
branch
from
a3f4859
to
f230d55
Compare
zhoxing-ms
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pr is part of main...VSChina:enterprise.
This PR adds "az spring-cloud service-registry" command groups, including three commands:
az spring-cloud service-registry show -s xx -g xxShow the properties of service registry,
az spring-cloud service-registry bind -s xx -g xx --appBind an app to service registry
az spring-cloud service-registry unbind -s xx -g xx --appUnind an app to service registry
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.