Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] Create a new extension image-gallery #4050

Merged
merged 7 commits into from
Nov 1, 2021

Conversation

zhoxing-ms
Copy link
Contributor

@zhoxing-ms zhoxing-ms commented Nov 1, 2021

Feature request: Azure/azure-cli#19882

Related PR: Azure/azure-cli#20129

Add a new extension to support requirements related to image gallery (include community gallery)

Please note that at present, due to the REST service does not release the features of list operation, so the code related to list operation has been hidden by comments


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

src/image-gallery/setup.py Outdated Show resolved Hide resolved
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 1, 2021

Compute

@yonzhan yonzhan added this to the Nov 2021 (2021-12-07) milestone Nov 1, 2021
@zhoxing-ms zhoxing-ms merged commit c2321b8 into Azure:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants