Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} AKS snapshot related commands #4046

Merged
merged 14 commits into from
Nov 3, 2021
Merged

{AKS} AKS snapshot related commands #4046

merged 14 commits into from
Nov 3, 2021

Conversation

chengliangli0918
Copy link
Contributor

@chengliangli0918 chengliangli0918 commented Oct 29, 2021

  • Add support for new snapshot commands
    • az aks snapshot create
    • az aks snapshot delete
    • az aks snapshot list
    • az aks snapshot show
  • Add --snapshot-id to creating/upgrading commands
    • az aks create --snapshot-id
    • az aks nodepool add --snapshot-id
    • az aks nodepool upgrade --snapshot-id

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 29, 2021

aks

@chengliangli0918 chengliangli0918 changed the title Charlili/snapshotcmd AKS snapshot related commands Oct 29, 2021
@chengliangli0918 chengliangli0918 changed the title AKS snapshot related commands {AKS} AKS snapshot related commands Oct 29, 2021
@FumingZhang
Copy link
Member

Due to some problems with the PR trigger, I manually queued a live test pipeline and the result shows everything works fine.

@zhoxing-ms zhoxing-ms merged commit 3cbe263 into Azure:main Nov 3, 2021
@chengliangli0918 chengliangli0918 deleted the charlili/snapshotcmd branch November 4, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants