[Logz.io] Release an experimental version #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
logz |
necusjz
force-pushed
the
feature-logz-onboard
branch
from
2bd2046
to
893f9ad
Compare
necusjz
changed the title
necusjz
force-pushed
the
feature-logz-onboard
branch
8 times, most recently
from
51bffec
to
138b9dd
Compare
necusjz
changed the title
kairu-ms
reviewed
Oct 28, 2021
kairu-ms
reviewed
Oct 28, 2021
|
|
||
| helps['logz monitor list-payload'] = """ | ||
| type: command | ||
| short-summary: "Returns the payload that needs to be passed in the request body for installing Logz.io agent on a \ |
There was a problem hiding this comment.
Please copy _help.py into manual folder. Update short summaries.
Suggested change
| short-summary: "Returns the payload that needs to be passed in the request body for installing Logz.io agent on a \ | |
| short-summary: "List the payload that needs to be passed in the request body for installing Logz.io agent on a \ |
kairu-ms
reviewed
Oct 28, 2021
Comment on lines
+142
to
+143
| short-summary: "Sending request to update the collection when Logz.io agent has been installed on a VM for a given \ | ||
| monitor." |
There was a problem hiding this comment.
Suggested change
| short-summary: "Sending request to update the collection when Logz.io agent has been installed on a VM for a given \ | |
| monitor." | |
| short-summary: "Update the collection when Logz.io agent has been installed on a VM for a given \ | |
| monitor." |
kairu-ms
reviewed
Oct 28, 2021
|
|
||
| helps['logz sso show'] = """ | ||
| type: command | ||
| short-summary: "Gets the Logz single sign-on resource for the given Monitor." |
There was a problem hiding this comment.
Suggested change
| short-summary: "Gets the Logz single sign-on resource for the given Monitor." | |
| short-summary: "Get the Logz single sign-on resource for the given Monitor." |
kairu-ms
reviewed
Oct 28, 2021
|
|
||
| helps['logz sso create'] = """ | ||
| type: command | ||
| short-summary: "Configures single-sign-on for this resource. This operation can take upto 10 minutes to complete." |
There was a problem hiding this comment.
Suggested change
| short-summary: "Configures single-sign-on for this resource. This operation can take upto 10 minutes to complete." | |
| short-summary: "Create single-sign-on for this resource." |
kairu-ms
reviewed
Oct 28, 2021
|
|
||
| helps['logz sso update'] = """ | ||
| type: command | ||
| short-summary: "Configures single-sign-on for this resource. This operation can take upto 10 minutes to complete." |
There was a problem hiding this comment.
Suggested change
| short-summary: "Configures single-sign-on for this resource. This operation can take upto 10 minutes to complete." | |
| short-summary: "Update single-sign-on for this resource." |
kairu-ms
reviewed
Oct 28, 2021
Comment on lines
+346
to
+347
| short-summary: "Create sub account under a given monitor resource. This create operation can take upto 10 minutes \ | ||
| to complete." |
There was a problem hiding this comment.
Suggested change
| short-summary: "Create sub account under a given monitor resource. This create operation can take upto 10 minutes \ | |
| to complete." | |
| short-summary: "Create sub account under a given monitor resource. " |
|
Good job. |
* rename command group * simplify several commands * add alias for long parameter * add replacer for credential scan * fix style and linter check
necusjz
force-pushed
the
feature-logz-onboard
branch
from
96497ca
to
339406b
Compare
kairu-ms
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft pull request for Logz.io.
Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.