appservice-kube extension #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar issue to retrive triggers from a function app
Removing trailing white spaces
Removing trailing white spaces
…no user name and password supplied
…correcting the lookup path
…ld parameters from commands
calvinsID
reviewed
Oct 22, 2021
This comment has been minimized.
This comment has been minimized.
calvinsID
approved these changes
Oct 25, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
reviewed
Oct 26, 2021
Comment on lines
+15
to
+17
| # TODO | ||
| class AppserviceKubernetesScenarioTest(ScenarioTest): | ||
| pass |
There was a problem hiding this comment.
Why is there no scenario tests here?
There was a problem hiding this comment.
The process of setting up an AKS cluster to put kubernetes environments in (see here) is quite lengthy/time-consuming and doesn't lend itself well to automated testing. So far, we've been manually testing the commands
I was under the impression that scenario tests are essential for CLI features but not necessarily CLI extensions
There was a problem hiding this comment.
@zhoxing-ms we plan to add scenario tests before we move this core-cli, after making updates to use the latest version of the SDK.
There was a problem hiding this comment.
OK, I'll approve this PR first. Please supplement these tests in a new PR
zhoxing-ms
reviewed
Oct 26, 2021
zhoxing-ms
approved these changes
Oct 27, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.