implement aks gpu instance profile #3895
Conversation
alexeldeib
requested review from
andyliuliming and
zqingqing1
as code owners
alexeldeib
force-pushed
the
ace/mig
branch
4 times, most recently
from
f3435c6
to
ccbe8cb
Compare
|
aks |
|
It seems that the live test pipeline failed on a removed test case |
|
ah sorry, I mixed up the tests with this and #3896 |
|
I'll exclude the live test due to feature registration, unfortunately same issue applies to #3896 |
| @@ -140,6 +142,7 @@ def load_arguments(self, _): | |||
| c.argument('enable_secret_rotation', action='store_true') | |||
| c.argument('assign_kubelet_identity', type=str, validator=validate_assign_kubelet_identity) | |||
| c.argument('disable_local_accounts', action='store_true') | |||
| c.argument('gpu_instance_profile', arg_type=get_enum_type([CONST_GPU_INSTANCE_PROFILE_MIG1_G, CONST_GPU_INSTANCE_PROFILE_MIG2_G, CONST_GPU_INSTANCE_PROFILE_MIG3_G, CONST_GPU_INSTANCE_PROFILE_MIG4_G, CONST_GPU_INSTANCE_PROFILE_MIG7_G])) | |||
There was a problem hiding this comment.
May consider using a variable to wrap these options?
|
@FumingZhang anything we're waiting on here for merge? |
|
@alexeldeib Please write those changes into the By the way, do you need to release a new version for these changes? If so, please also update the |
|
@alexeldeib Could you please address those conflicts? |
|
rebased 👍 |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.