-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front Door and Express Route extensions. #330
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
"summary": "Manage networking FrontDoors.", | ||
"version": "0.1.0" | ||
"summary": "Manage networking Front Doors.", | ||
"version": "0.1.1" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you publishing express routes too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already published. The Front Door extension needed a version bump because the help text changed.
azure-cli-extensions.pyproj.user
Outdated
<PropertyGroup> | ||
<ProjectView>ProjectFiles</ProjectView> | ||
</PropertyGroup> | ||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there so many visual studio files added? are they all necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally, to support @yugangw-msft and my effort to make developing for extensions the same as the regular CLI. That means have a VS proj and sln file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's 6 added visual studio related files?..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can I say--it's visual studio 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cut back on the number of commit VS files. It should be 4 now.
Moves Front Door and Express Route extensions into public extensions repo. Updates Front Door for help text changes.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.sh
locally? (pip install pylint flake8
required)python scripts/ci/test_index.py -q
locally?For new extensions: