Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front Door and Express Route extensions. #330

Merged
merged 4 commits into from
Oct 8, 2018
Merged

Front Door and Express Route extensions. #330

merged 4 commits into from
Oct 8, 2018

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Oct 3, 2018

Moves Front Door and Express Route extensions into public extensions repo. Updates Front Door for help text changes.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@tjprescott tjprescott requested a review from williexu as a code owner October 3, 2018 22:01
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/tjprescott/azure-cli-extensions.git@MovePrivateExtensions#subdirectory=src/$EXT&egg=$EXT"

@tjprescott tjprescott changed the title Move private extensions Front Door and Express Route extensions. Oct 3, 2018
"summary": "Manage networking FrontDoors.",
"version": "0.1.0"
"summary": "Manage networking Front Doors.",
"version": "0.1.1"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you publishing express routes too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already published. The Front Door extension needed a version bump because the help text changed.

<PropertyGroup>
<ProjectView>ProjectFiles</ProjectView>
</PropertyGroup>
</Project>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many visual studio files added? are they all necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally, to support @yugangw-msft and my effort to make developing for extensions the same as the regular CLI. That means have a VS proj and sln file.

Copy link
Contributor

@williexu williexu Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's 6 added visual studio related files?..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say--it's visual studio 🤷‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cut back on the number of commit VS files. It should be 4 now.

@tjprescott tjprescott merged commit 5bc1bee into Azure:master Oct 8, 2018
@tjprescott tjprescott deleted the MovePrivateExtensions branch October 8, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants