Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Virtual-Wan] migrate to track2 #3273

Merged
merged 17 commits into from
Apr 21, 2021

Conversation

00Kai0
Copy link
Contributor

@00Kai0 00Kai0 commented Apr 19, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@00Kai0 00Kai0 requested a review from jsntcy April 19, 2021 02:41
@00Kai0 00Kai0 requested a review from kairu-ms as a code owner April 19, 2021 02:41
@yonzhan yonzhan added this to the S186 milestone Apr 19, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 19, 2021

Virtual wan on Track 2

@jsntcy
Copy link
Member

jsntcy commented Apr 21, 2021

@00Kai0, BTW, don't forget upgrade extension version and add release notes.

@00Kai0 00Kai0 changed the title Virtual wan migrate to track2 [Virtual-Wan] migrate to track2 Apr 21, 2021
Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsntcy jsntcy self-requested a review April 21, 2021 10:00
@jsntcy jsntcy merged commit 3ee1ed1 into Azure:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants