Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update trigger condition #1388

Merged
merged 3 commits into from
Mar 16, 2020
Merged

[CI] Update trigger condition #1388

merged 3 commits into from
Mar 16, 2020

Conversation

mitchdenny
Copy link
Contributor

This is just a suggestion for how I would setup my PR and CI triggers on your YAML file.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/mitchdenny/azure-cli-extensions.git@trigger-suggestion#subdirectory=src/$EXT&egg=$EXT"

@mitchdenny mitchdenny changed the title My suggestion for triggers. Trigger suggestion Mar 13, 2020
@yonzhan yonzhan added this to the S167 milestone Mar 13, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 13, 2020

add to S167

@haroldrandom haroldrandom changed the title Trigger suggestion [CI] Update trigger condition Mar 16, 2020
haroldrandom
haroldrandom approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@haroldrandom haroldrandom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested in the scenario that disabling the option "Overwrite the YAML request trigger from here".
It worked.

image

@haroldrandom haroldrandom merged commit 8a8d551 into Azure:master Mar 16, 2020
@haroldrandom haroldrandom mentioned this pull request Mar 19, 2020
Merged
2 tasks
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
@mitchdenny @ManuInNZ
[CI] Update trigger condition (Azure#1388)
dbeef28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haroldrandom haroldrandom haroldrandom approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Assignees

@haroldrandom haroldrandom

Labels
None yet
Projects
None yet
Milestone
S167
Development

Successfully merging this pull request may close these issues.
5 participants
@mitchdenny @azuresdkci @yonzhan @haroldrandom @fengzhou-msft