Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move 1: Copy job SourceStaticPy from Travis to ADO (5/6) #1156

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

haroldrandom
Copy link
Contributor

This is the first move for CI that migrate from Travis to ADO which will move job SourceStaticPy to ADO and renamed it as StaticAnalysis.

This PR is 5/6 part of this move. Basically done is to enable the rest of checking in ADO:

  • Enable flake8 on extension
  • Enable pylint on CI scripts
  • Enable flake8 on CI scripts
  • Enable code owner and license checks

Respect #867


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@migrate-travis-to-ado-1-1.2#subdirectory=src/$EXT&egg=$EXT"

.flake8 Show resolved Hide resolved
pylintrc Show resolved Hide resolved
@jsntcy
Copy link
Member

jsntcy commented Dec 18, 2019

I'm curious why the PR title is the same as the one you created last time?


In reply to: 566479337 [](ancestors = 566479337)

@haroldrandom
Copy link
Contributor Author

haroldrandom commented Dec 18, 2019

I'm curious why the PR title is the same as the one you created last time?

In reply to: 566479337 [](ancestors = 566479337)

Not the same. The old one is [CI] Move 1: Copy job SourceStaticPy from Travis to ADO (1/6)

@jsntcy
Copy link
Member

jsntcy commented Dec 18, 2019

So how many sub-steps are left for your move 1?


In reply to: 566863429 [](ancestors = 566863429)

@haroldrandom
Copy link
Contributor Author

haroldrandom commented Dec 18, 2019

So how many sub-steps are left for your move 1?

In reply to: 566863429 [](ancestors = 566863429)

None. This is the last step of Move 1.

@zikalino zikalino merged commit 7c5a7e2 into Azure:master Dec 18, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
…1156)

* Enable flake8 on extension in ADO

* Enable pylint on CI scripts in ADO

* Enable flake8 on CI scripts in ADO

* Enable code owner and license checks in ADO

* Fix bug: pylint==1.9.5 didnt recognize disable=too-many-lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants