--input-path should accept other encoding types besides UTF-8 encoding (

#5181)
Azure · Aug 3, 2022 · eb35ad2 · eb35ad2
1 parent cf1ee43
commit eb35ad2
Show file tree

Hide file tree

Showing 6 changed files with 110 additions and 67 deletions.
diff --git a/src/portal/HISTORY.rst b/src/portal/HISTORY.rst
@@ -3,6 +3,10 @@
 Release History
 ===============
 
+0.1.3
+++++++
+* [Fix] `az portal dashboard`: `--input-path` should accept other encoding types besides UTF-8 encoding.
+
 0.1.1
 ++++++
 * Initial release.
diff --git a/src/portal/azext_portal/generated/custom.py b/src/portal/azext_portal/generated/custom.py
@@ -56,7 +56,7 @@ def portal_dashboard_import(cmd, client,
 
 def parse_properties_json(input_path):
     try:
-        with open(input_path) as json_file:
+        with open(input_path, 'rb') as json_file:
             try:
                 properties = json.load(json_file)
             except json.decoder.JSONDecodeError as ex:

diff --git a/src/portal/azext_portal/tests/latest/properties-update.json b/src/portal/azext_portal/tests/latest/properties-update.json
@@ -1,4 +1,4 @@
-{
+{
   "lenses": {
     "0": {
       "order": 0,