Skip to content

Fixed tooltip button position and scrolling on subscription rename/cancel #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ygrik
Copy link
Contributor

@ygrik ygrik commented Nov 20, 2024

Fixed tooltip button position and scrolling on subscription rename/cancel

Fixed scrolling on subscription rename/cancel
@ygrik ygrik requested a review from jsorohova November 20, 2024 00:51
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@ygrik ygrik merged commit 07cacac into master Nov 20, 2024
9 checks passed
azaslonov pushed a commit that referenced this pull request Mar 21, 2025
Fixed scrolling on subscription rename/cancel
ygrik added a commit that referenced this pull request Mar 25, 2025
Runtime UI redesign using Fluent UI with previous default.json for e2e tests and static build

* Fixed nested definitions listing (#2315)

* Registered operationDetails widget (#2323)

* Fixed Product APIs registration (#2324)

* feat: add option to configure a default to expand all group tags (#2330)

* Admin UI redesign (#2121)

* Boostrapped React-based admin panel.

* Navigation top level

* Navigation - pages

* Pages navigation item

* Delete confirmation code improvement

* Navigation 'Navigation' item

* Settings and Help navigation items, Top panel

* Page/Layout modals

* Media modal

* Media modals

* Focused layout

* Styles and Custom widgets items

* Mobile styles

* URLs navigation item

* Toast notifications

* Site menu

* Favicon upload

* Popups item

* Onboarding modal

* Components updates

* Anchors and bug fixes

* Content changes

* Validation implementation

* Reset content flow restyling

* Pagination support

* Loaders and content changes

* Permalink validation fixes

* Feedback link change

---------

Co-authored-by: Alexander Zaslonov <alzaslon@microsoft.com>

* Pagination simplified for data API (#2304)

* Accessibility fixes (#2343)

* Nav link color fix (#2346)

* Fixed: UTF-8 characters that have more than 1 byte get truncated by migrate scripts (#2348)

* API operation-details - use correct protocol (#2357)

* APIs dropdown close fix and Product API widget target fix (#2352)

* Fixed Settings modal incorrect behaviour (#2361)

* Packages update - custom widgets overrides default widget fix (#2363)

* api-management-custom-widgets packages updated

* npm audit fix

* Increase dev-portal version to 2.25.0

* skipWorkspaces query param added to APIs & Products services (#2366)

* Fixed error when changing OAuth flow (#2368)

* Fixed error when changing oauth flow

* added missing removeEventListener in finally clause

* added check to ensure the popup is closed (in case the user cancels the flow manually)

* refactoring

* Fixed: custom HTML widget not rendering on published portals (#2370)

* Validation fixes (#2374)

* Fixed Link media functionality (#2377)

* Fixed: error when loading operations grouped by tags without apiId (#2376)

* Fixed: error when loading subscriptions without user signed in (#2375)

* iframe sandbox allowed tags fixed for safari

* Fixed subscription header always required (#2382)

* Fixed subscription header always required

* remove set selectedSubscriptionKey to null

* use of outdated custom widget scaffolder by npx fixed (#2383)

* Added role view dropdown (#2378)

* Update to 2.26 version

Update version on package.json to 2.26 for preparing release

* Disable reset password for signed in users (#2308)

* Disable reset password for signed in users

* code review fix

* Fixed heavily truncated description for APIs and Products (#2386)

* Added mime type to media linking (#2390)

* GitHub CI permissions change (#2393)

* GitHub CI permissions change

* Added a check permission

* Paperbits version bump (#2391)

* Fixed media empty permalink errors (#2395)

* Bumped paperbits version to sync with the managed (#2397)

* Fixed non-working anchors for definitions, made multiple complex schemas more readable (#2389)

* Fixed non-working anchors for definitions, made multiple complex schemas more readable

* Changed the logic of scrolling to the definition

* Fixed management API version mismatch (#2385)

* Fixed management API version mismatch

* Changed test settings to use the new endpoint

* Changed test data jsons

* Added UI interface for multiple auth servers (#2337)

* Added ui interface for multiple auth servers

* added nullchecks

* fixed typo

* extracted serverName in constant

* Upgrade dependency follow-redirects (#2401)

* Commented out markdown announcement

* Deleted markdown announcement slide

* Fixed default home page menu text color (#2406)

* Bump undici from 5.28.2 to 5.28.3 (#2410)

Bumps [undici](https://github.com/nodejs/undici) from 5.28.2 to 5.28.3.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.2...v5.28.3)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed: registered apiProducts widget correctly (#2411)

* Fixed validation behaviour (#2412)

* Used naming cinvention with dash (#2414)

* fixed api products widget editor registration (#2416)

* Improved logging around AAD B2C flows (#2402)

* Improved logging around AAD B2C flows

* ran lint:fix

* Move default media files to regional storage (#2407)

* Moved default media files to regional storage and change endpoints to use them accordingly

* fixed default.json conflicts

* code review changes

* Alt tag for images in the Media modal (#2423)

* Fixed: API not loaded the first time (#2424)

* aria-label attributes for fields with custom labels (#2427)

* Fixed multiple media files deletion (#2434)

* Update issue templates (#2436)

* Create cleanUpOpenedIssues.yml

Test: Execute github action to clean up existing opened issues

* Update cleanUpOpenedIssues.yml

* Update cleanUpOpenedIssues.yml

Update token

* Update cleanUpOpenedIssues.yml

* Update cleanUpOpenedIssues.yml

* Update cleanUpOpenedIssues.yml

* Update cleanUpOpenedIssues.yml

* Update cleanUpOpenedIssues.yml

using bash to fetch issues urls

* Fixed non-closing list of APIs dropdown widget (#2450)

* Prepare release 2.27

Setting up "version": "2.27.0" on package.json to start preparing release

* Update package-lock.json

Update 2.27 version on package-lock.json

* Migration script: added recursive download of media data from content… (#2457)

* Migration script: added recursive download of media data from content storage

* Added to scripts v2

---------

Co-authored-by: Roman Kolesnikov <rokolesnikov@microsoft.com>

* Fixed overlapping API dropdown (#2459)

* API Dropdown - navigation fix (#2460)

* Revert "Move default media files to regional storage (#2407)" (#2461)

This reverts commit 64ee99e.

* Fix scripts.v2: migrate & capture (#2465)

Co-authored-by: Roman Kolesnikov <rokolesnikov@microsoft.com>

* Fixed auth servers in test console on switching apis (#2471)

* Fixed enum values processing for console operations query and template parameters (#2476)

* Fixed toast notifications to appear on top of the Fluent UI overlays (#2484)

* Fixed do not show AAD config message in runtime for sigin social widget (#2485)

* FUI - List of operations (#2475)

* FUI - List of operations (#2490)

* FUI - List of operations

* FUI - List of operations - GQL

* FUI - Operation list - CR fixes and router listener

* FUI - List of operations - a11y fixes

* FUI - List of operations - a11y fixes

* FUI - List of operations - a11y fixes

* FUI - API details (#2483)

---------

Co-authored-by: Elena Shorohova <jsorohova@microsoft.com>
Co-authored-by: Elena Shorohova <92329687+jsorohova@users.noreply.github.com>

* FUI - API details (#2489)

* FUI - List of operations

* FUI - List of operations - GQL

* FUI - API details

* FUI - API details

* FUI - Operation list - CR fixes and router listener

* FUI - API details - router listener

* FUI - List of operations (#2475)

* FUI - APIs list (#2431)

* APIs List V2 - init

* APIs List V2 - APIs List v2

* APIs List V2 - @fluentui/react-components

* APIs List V2 - TODO

* APIs List V2 - api-list base working

* APIs List V2 - api-list pagination working

* APIs List V2 - api-list first row info

* APIs List V2 - api-list cards & fuiTheme fix

* APIs List V2 - ApisCards

* APIs List V2 - cleanup

* APIs List V2 - npm i

* APIs List V2 - search & group by WiP

* APIs list - group by tag & sorting WiP (TODO)

* merge - styling refactor

* page size fix

* merge fix

* refactor of style handling

* markdown processing

* margin adjusted

* FUI - Products list (#2492)

* FUI - list of APIs in a Product (#2493)

* FUI - filters for list pages (#2496)

* Fixed Custom widgets CORS issue in Safari (#2498)

[28254976]

* FUI - Redesign toggle (#2500)

* FUI - APIs list Dropdown (#2501)

* APIs list - as Dropdown

* APIs list Dropdown - links

* FUI Dropdown - loading default value & styling

* FUI - list-of-apis isRedesignEnabled

* FUI - product-list isRedesignEnabled

* FUI - Products list Dropdown (#2503)

* FUI - product-apis isRedesignEnabled

* FUI - Products list as Dropdown

* FUI - added option to hide filters

* FUI - product-apis refresh on Product change fix

* FUI - redesigned filter popup for only one filter group

* FUI - min-width fixed

* FUI - APIs list style adjustments

* FUI - Redesign toggle - Stickness adjustment (#2508)

* FUI - Product Subscriptions list (#2510)

* FUI - products subscriptions list

* FUI - products dropdown formatting

* FUI - Subscribe to a Product (#2511)

* FUI - products subscriptions list

* FUI - products dropdown formatting

* FUI - API details badges added

* FUI - Product Subscribe + ToS

* FUI - Product details (#2513)

* Added pagination and filter support for subscriptions in the test console (#2516)

* Added pagination and filter support for subscriptions in the test console

* simplified if statement

* added nullcheck

* Use basic auth for change password (#2396)

* FUI - Operation details widget (#2517)

* FUI - Sign in (#2518)

* FUI - signin

* sign in fixes

* FUI - Sign In Social (#2519)

* FUI - Profile (#2520)

* FUI - Subscriptions (#2521)

* FUI - minor fixes found in testing in Managed portal (#2523)

* FUI - pagination "hasNextPage" variant added (#2524)

* FUI - Operation details - GQL (#2525)

* FUI - Validation summary (#2528)

* FUI - Sign Up + Captcha (#2529)

* FUI - Reset password (#2530)

* Bumped version to 2.29 (#2531)

* browser specific iframe sandbox tokens support (#2514)

* browser specific iframe sandbox tokens support

* missing semicolon

* check all tokens to be safe

* changes requested by igor

* FUI - Tags filtering for APIs Group by Tag view (#2533)

* Reverted accidential redesign merge (#2532)

* FUI - Sign Up AAD (#2535)

* Create config.yml (#2536)

* Update README.md (#2641)

* Update bug_report.md (#2647)

* What's new modal refactoring (#2657)

* Whats new modal refactoring

* Fixed a11y issue for slides headings

* Role and screen size dropdowns accessibility fix (#2659)

* Made several left nav items keyboard accessible (#2660)

* Multiple fixes for Site menu item modal (#2661)

* FUI - Operation console (#2655)

* FUI - Operation console

* Removed paging from test console subscriptions dropdown (#2664)

Limit dropdown with 50 subscriptions (100 keys)
Improved subscriptions secrets load

* Developer portal version bump to 2.30 (#2662)

* Fixed grouping apis subscriptions in test console selector (#2665)

* Error processing and search fixes in Admin UI (#2666)

* Error processing and search fixes in Admin UI

* Fixed permalink validation in the page admin modal

* Added a fix for incorrect validation (#2668)

* CR fix (#2669)

* FUI - WS console (#2670)

* FUI - Reports page (#2672)

* FUI - Reports

* FUI - Reports

---------

Co-authored-by: Jan Mach <janmach1@microsoft.com>

* FUI - Console body improvements and bug fixes (#2673)

* FUI - code review & minor changes

* FUI - Console body improvements and bug fixes

---------

Co-authored-by: Jan Mach <janmach1@microsoft.com>

* FUI - Console body improvements and bug fixes (#2674)

* FUI - code review & minor changes

* FUI - Console body improvements and bug fixes

* FUI - Reports charts npm package

---------

Co-authored-by: Jan Mach <janmach1@microsoft.com>

* FUI - API changelog page (#2675)

* FUI - Change password page (#2676)

* FUI - Confirm password page (#2677)

* Fixed integration user errors (#2679)

* Fixed integration user errors

* Fixed GitHub build errors

* FUI - Covering No data scenarios and small fixes (#2680)

* FUI - SOAP headers and console bug fixes (#2681)

* FUI - SOAP headers and console bug fixes

* FUI - Added check for SOAP headers urlTemplate

* Fixed custom widgets editor configuration view (#2686)

Co-authored-by: Roman I. Kolesnikov false <rokolesnikov@microsoft.com>

* Added allow-same-origin as a settings option for custom widgets (#2688)

* Added cors allo-same-origin option for custom widget

* Nit, changed text

* Update package version to 2.31.0 (#2689)

* Update package version to 2.31.0

---------

Co-authored-by: Roman I. Kolesnikov false <rokolesnikov@microsoft.com>

* Fixed nonImageDetailModal to pass schema validation on saving of linked item (#2691)

Co-authored-by: Roman I. Kolesnikov false <rokolesnikov@microsoft.com>

* Packages and styles upgrade (#2692)

* Migrated declarations.
* Upgraded designer styles.
* Updated packages and fixed styles

---------

Co-authored-by: Alexander Zaslonov <alzaslon@microsoft.com>

* Merged PR 10992070: fix(sitemenu): Fix linking for image site menu -> media modal

**Problem:**
Link image doesn't work for media because of missed property compared to schema

**Solution:**
Fixed

**Synchronization:**
_Describe If there is any condition to merge this code to main repository. Link any PR that is needed to be deployed together with this PR._

**Type of change:**

- [ ] Feature work
- [X] Bugfix
- [ ] Security patch
- [ ] Documentation
- [ ] Engineering change
- [ ] Test
- [ ] Logging/Metrics

_Before submitting this PR, please make sure that the following are done_:

- [ ] There is sufficient test coverage (unit/BVT)
- [ ] There is sufficient logging and metrics to troubleshoot in production. Ensured PII is not logged
- [ ] Validated that it is not introducing breaking changes in the product behavior

**Risk**:

- [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high-level infrastructure changes)
- [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
- [X] Small – No issues are expected. (Example: Very small bugfixes, string changes, or configuration settings changes)

Related work items: #29755670

* Merged PR 11000481: fix(media): Fixed reference url is not updatable

**Problem:**
When you try to put value to reference url in limk media dialog, the value is not updated

**Solution:**
Fixed state updates

**Synchronization:**
_Describe If there is any condition to merge this code to main repository. Link any PR that is needed to be deployed together with this PR._

**Type of change:**

- [ ] Feature work
- [X] Bugfix
- [ ] Security patch
- [ ] Documentation
- [ ] Engineering change
- [ ] Test
- [ ] Logging/Metrics

_Before submitting this PR, please make sure that the following are done_:

- [X] There is sufficient test coverage (unit/BVT)
- [ ] There is sufficient logging and metrics to troubleshoot in production. Ensured PII is not logged
- [X] Validated that it is not introducing breaking changes in the product behavior

**Risk**:

- [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high-level infrastructure changes)
- [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
- [X] Small – No issues are expected. (Example: Very small bugfixes, string changes, or configuration settings changes)

Related work items: #29755670

* Fixed styles after last packages update (#2694)

* Fixed styles after last packages update

* Returned default styles from style guide

* merge from master

* Update Paperbits packages and styles in api list widget (#2696)

* Fixed styles after packages upgrade (#2697)

* Removed unnecessary imports from styles

* Fixed admin dropdown on small screen resolutions

* Fixed tabs styles and editor alignments (#2698)

* Developer portal version bump to 2.32 (#2699)

* Migrate design-time and editor to React (#2700)

* clean up

* FUI - Moving to the native elements - Sign in and Product pages (#2702)

* FUI - Moving to the native elements - Required label (#2704)

* FUI - Moving to the native elements - Required label - Added missed variable (#2705)

* Signup migrate to simple elements, captcha redesign (#2703)

Signup migrate to simple elements
Cleanup content for signup and new captcha
Fixed validation summary

* chore: Remove unused workflow (#2706)

* Fixed publishing

* FUI - Moving to the native elements - API list (#2707)

* FUI - Moving to the native elements - Product list (#2708)

* Fixed sign up social widget

* Accessibility fixes for new Admin UI (#2710)

* Migrated reset password widget and editor
Updated paperbits packages

* Migrated change password widget and editor

* Migrated confirm password to editor runtime

* Merge

* FUI - API products (#2712)

* Migrated subscription widget

* Migrated profile widget editor runtime to React

* Paperbits packages upgrade to 0.1.629 (#2713)

* Migrated signin social to React editor runtime

* Migrated details of api widget

* migrated api history widget to React editor runtime

* migrated operation list to React design runtime

* remove migrated templates

* Update license reference (#2716)

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>

* Fixed pages and layouts validation and added No items text when searching (#2715)

* Fixed terms of use widget

* FUI - Operation details - Moving to native elements (#2718)

* Migrated to simple elements and implemented cancel for editing mode for Profile and Subscriptions table components

* FUI - Reports - Moving to native elements (#2721)

* Fixed forms styles (#2722)

* Fixed layouts validation (#2723)

* Fixed tooltip button position (#2724)

Fixed scrolling on subscription rename/cancel

* FUI - React runtime files, Search field and Profile page adjustments (#2725)

* FUI - Migration to native elements - React runtime

* FUI - Moving to native elements - Search field

* FUI - Fixed Profile page Account table styles

* FUI - Profile page Subscriptions full table adjustments

* Master branch merge (#2726)

* FUI - React runtime files - Products and User (#2728)

* FUI - React runtime files - Products

* FUI - React runtime files - User

* FUI - React runtime files - Renaming (#2729)

* Added new password validation must be different from old (#2730)

* Update package.json engines to require Node pre v20 (#2731)

* Update package.json engines to require Node pre v20

* upd

* Add IDEA specific files to .gitignore (#2732)

* Fixed filtering by tag for apis widget (#2735)

* Fixed filtering by tag for apis widget

* Fixed editor update event propagate to widget (#2737)

* Fixed:
Operation details does not show request headers and parameters and Required headers were NOT added in test Console

* Added validation for required parameters and headers in Operation console (#2739)

* Added reveal secret button and removed tags from HTTP response content format (#2740)

* FUI - Removed autocomplete for search to fix Edge behaviour (#2742)

* Upgraded Paperbits libraries to 0.1.631

* FUI - Removed autocomplete for search to fix Edge behaviour

* Fixed examples displaying in the Operation details widget in knockout (#2745)

* Fixed Page name displaying in admin top panel (#2749)

* Paperbits packages upgrade to 0.1.632 (#2748)

* Master merge into fui/master (#2750)

* FUI - Fixed GraphQL console fields (#2751)

* FUI - Visual code improvements (#2752)

* Implemented service worker to intercept network traces, added tracking simple page navigation (#2743)

* Added sent page load metrics to backend logs
* Added service worker, network traces and tracking simple page navigation
* Clean sensitive data from traces parameters
* Added feature flag for client telemetry
* added clean up worker if feature flag is disabled
* extended user event logging for buttons clicks
* improved logging messages format
* set console logger by default and improved user interaction logging

* FUI - Fixed invalid query variables format (#2753)

* Popup over collapsible menu z-index fix (#2754)

* FUI - Fixed multiple bugs

* FUI - Fixed multiple bugs (#2757)

* FUI - Fixed font not being customizable

* FUI - Fixed font not being customizable (#2758)

* FUI - Getting language from content-type header in GQL console

* FUI - Getting language from content-type header in GQL console (#2759)

* FUI - Fixed get header function

* FUI - Removed setting language for the response

* Updated packages and GQL response formatting

* Added runtime redesign content snapshot

* Fixed sign in button width

* Fixed required styles for parameters in test console

* Changed image uris in the default content (#2760)

Co-authored-by: Roman I. Kolesnikov false <rokolesnikov@microsoft.com>

* FUI - Pagination rework for API and Product lists (#2770)

* Updated operations layout.

* Upgraded libraries.

* Upgraded libraries.

* FUI - Pagination accessibility adjustments (#2772)

* FUI - Scrollable tables and fixed form data inputs (#2773)

* FUI - Margin fixes and updated template file (#2774)

* Updated picture URLs in the default template.

* Updated labels on signup form buttons.

* FUI - Redesign enabling logging (#2775)

* FUI - Redesign enabling logging in runtime (#2776)

* Reverted default.json file content

* FUI - Captcha size and custom widgets configs load fixes

* Fixing failing e2e tests

* maxDiffPixels property fix

* FUI - Added support to reset portal to old default.json with feature flag setting

* FUI - Setting for enabling new or old theme (#2778)

* FUI - GQL console WS part (#2779)

* Try/catch-es for isRedesignEnabled setting (#2780)

* Try/catch-es for isRedesignEnabled setting

* FUI - Logger in GQL console

* FUI - Bug fixes for User pages (#2781)

* Fixed static build with old data

* Adjusted tests for the latest UI

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Michael Liu <practicalvb@yahoo.com>
Co-authored-by: malincrist <92857141+malincrist@users.noreply.github.com>
Co-authored-by: jan-mrm <67435696+jan-mrm@users.noreply.github.com>
Co-authored-by: Alexander Zaslonov <alzaslon@microsoft.com>
Co-authored-by: Ján Mach <92859870+JMach1@users.noreply.github.com>
Co-authored-by: Carlos Perez <carlosperez@microsoft.com>
Co-authored-by: Jan Mach <janmach1@microsoft.com>
Co-authored-by: Farhad Alizada <104755925+f-alizada@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sthirthala <38636149+sthirthala@users.noreply.github.com>
Co-authored-by: Roman Kolesnikov <14820428+rkolesnikovDX@users.noreply.github.com>
Co-authored-by: Roman Kolesnikov <rokolesnikov@microsoft.com>
Co-authored-by: Igor O <ygrik@hotmail.com>
Co-authored-by: Max Podriezov <maxpodriezov@microsoft.com>
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Co-authored-by: Eugene Tsakh <onatolich@gmail.com>
Co-authored-by: Igor O <igo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants