Skip to content

Accessibility fixes for new Admin UI #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/admin/custom-widgets/customWidgetDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class CustomWidgetDetailsModal extends React.Component<CustomWidgetDetail
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Custom widget / { this.state.customWidget.displayName }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Custom widget / { this.state.customWidget.displayName }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
{!this.state.isEdit &&
<PrimaryButton
Expand Down
2 changes: 1 addition & 1 deletion src/admin/help/helpModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class HelpModal extends React.Component<HelpModalProps, HelpModalState> {
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text className="admin-modal-header-text">Help and resources</Text>
<Text as="h2" className="admin-modal-header-text">Help and resources</Text>
<DefaultButton text="Close" onClick={this.props.onDismiss} />
</Stack>
<div className="admin-modal-content">
Expand Down
2 changes: 1 addition & 1 deletion src/admin/media/imageDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class ImageDetailsModal extends React.Component<ImageDetailsModalProps, I
containerClassName="admin-modal media-details-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Media / { this.state.mediaItem.fileName }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Media / { this.state.mediaItem.fileName }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/media/mediaModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export class MediaModal extends React.Component<MediaModalProps, MediaModalState
containerClassName="admin-modal media-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text className="admin-modal-header-text">Media</Text>
<Text as="h2" className="admin-modal-header-text">Media</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<DefaultButton text="Close" onClick={this.props.onDismiss} />
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion src/admin/media/mediaSelectionItemModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class MediaSelectionItemModal extends React.Component<MediaSelectionItemM
containerClassName="admin-modal media-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text className="admin-modal-header-text">Media</Text>
<Text as="h2" className="admin-modal-header-text">Media</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<DefaultButton text="Close" onClick={this.props.onDismiss} />
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion src/admin/media/nonImageDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export class NonImageDetailsModal extends React.Component<NonImageDetailsModalPr
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Media / { this.state.mediaItem.fileName }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Media / { this.state.mediaItem.fileName }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/navigation/navigationItemModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ export class NavigationItemModal extends React.Component<NavigationItemModalProp
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text className="admin-modal-header-text" block nowrap>Site menu item / { this.state.navItem.label }</Text>
<Text as="h2" className="admin-modal-header-text" block nowrap>Site menu item / { this.state.navItem.label }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/pages/pageDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class PageDetailsModal extends React.Component<PageDetailsModalProps, Pag
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Page / { this.state.page.title }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Page / { this.state.page.title }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/pages/pageLayoutDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export class PageLayoutDetailsModal extends React.Component<PageLayoutModalProps
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Layout / { this.state.layout.title }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Layout / { this.state.layout.title }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/popups/popupDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class PopupDetailsModal extends React.Component<PopupDetailsModalProps, P
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">Pop-up / { this.state.popup.title }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">Pop-up / { this.state.popup.title }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/settings/settingsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class SettingsModal extends React.Component<SettingsModalProps, SettingsM
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text className="admin-modal-header-text">Settings</Text>
<Text as="h2" className="admin-modal-header-text">Settings</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
2 changes: 1 addition & 1 deletion src/admin/urls/urlDetailsModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class UrlDetailsModal extends React.Component<UrlDetailsModalProps, UrlDe
containerClassName="admin-modal"
>
<Stack horizontal horizontalAlign="space-between" verticalAlign="center" className="admin-modal-header">
<Text block nowrap className="admin-modal-header-text">URL / { this.state.url.title }</Text>
<Text as="h2" block nowrap className="admin-modal-header-text">URL / { this.state.url.title }</Text>
<Stack horizontal tokens={{ childrenGap: 20 }}>
<PrimaryButton
text="Save"
Expand Down
6 changes: 6 additions & 0 deletions src/themes/designer/styles/admin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@
color: #fff;
font-size: 18px;
padding-right: 20px;
margin: 0;
}

.admin-modal-content {
Expand Down Expand Up @@ -284,6 +285,11 @@
}
}

// Required for accessibility
.ms-Fabric--isFocusVisible .onboarding-modal-close:focus {
background-color: rgba(255, 255, 255, .3);
}

.carousel-dots-container {
.carousel-dot {
height: 4px;
Expand Down
2 changes: 1 addition & 1 deletion src/themes/designer/styles/variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ $form-control-bg: #ffffff;
$form-control-bg-readonly: #ffffff;
$form-control-bg-disabled: #e6e7e8;
$form-control-padding: 7px;
$form-control-focus-color: #61b2e8;
$form-control-focus-color: #329be2;
$form-control-slider-thumb-bg: #fff;
$form-control-slider-thumb-size: 17px;
$form-collapsible-section-gutter-color: #ddd;
Expand Down
Loading