Skip to content

Commit fe5c83c

Browse files
authored
properly process unhandled error on logger error (#2148)
* prevent infinity loop on logging unhandled error * properly process unhandled error on logger error
1 parent 19271d1 commit fe5c83c

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/errors/unhandledErrorHandler.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ export class UnhandledErrorHandler {
88
}
99

1010
public handlerError(event: ErrorEvent): void {
11-
try {
12-
this.logger.trackError(event.error);
13-
} catch (error) {
14-
console.error(`Unable to log event.error: ${event.error} - Error:`, error);
15-
}
11+
event.preventDefault();
12+
event.stopPropagation();
13+
this.logger.trackError(event.error).catch((error) => {
14+
console.error(`Unable to log error: ${event.error} \n Logger issue -> `, error);
15+
});
1616
}
1717

1818
public handlerPromiseRejection(event: PromiseRejectionEvent): void {
19-
try {
20-
this.logger.trackError(event.reason);
21-
} catch (error) {
22-
console.error(`Unable to log Promise Rejection event.reason: ${event.reason} - Error:`, error);
23-
}
19+
event.preventDefault();
20+
event.stopPropagation();
21+
this.logger.trackError(event.reason).catch((error) => {
22+
console.error(`Unable to log Promise Rejection: ${event.reason} \n Logger issue -> `, error);
23+
});
2424
}
2525
}

0 commit comments

Comments
 (0)