Skip to content

Commit ddb5f4b

Browse files
authored
Validation fixes (#2374)
1 parent 5f57a94 commit ddb5f4b

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/admin/media/mediaModal.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,14 @@ export class MediaModal extends React.Component<MediaModalProps, MediaModalState
110110
}
111111

112112
renameMedia = async (mediaItem: MediaContract): Promise<void> => {
113-
const updatedMedia: MediaContract = {
114-
...mediaItem,
115-
fileName: this.state.fileNewName
113+
if (this.state.fileNewName) {
114+
const updatedMedia: MediaContract = {
115+
...mediaItem,
116+
fileName: this.state.fileNewName
117+
}
118+
await this.mediaService.updateMedia(updatedMedia);
119+
this.eventManager.dispatchEvent('onSaveChanges');
116120
}
117-
await this.mediaService.updateMedia(updatedMedia);
118-
this.eventManager.dispatchEvent('onSaveChanges');
119121

120122
this.setState({ fileForRename: '', fileNewName: '' });
121123
this.searchMedia();

src/admin/pages/pageDetailsModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class PageDetailsModal extends React.Component<PageDetailsModalProps, Pag
9898
}
9999

100100
validatePermalink = async (permalink: string): Promise<string> => {
101-
if (permalink === this.props.page?.permalink) return '';
101+
if (!this.state.copyPage && permalink === this.props.page?.permalink) return '';
102102

103103
const isPermalinkNotDefined = await this.permalinkService.isPermalinkDefined(permalink) && !reservedPermalinks.includes(permalink);
104104
const errorMessage = validateField(UNIQUE_REQUIRED, permalink, isPermalinkNotDefined);

src/admin/pages/pageLayoutDetailsModal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ export class PageLayoutDetailsModal extends React.Component<PageLayoutModalProps
7373
}
7474

7575
validatePermalink = async (permalink: string): Promise<string> => {
76-
if (permalink === this.props.layout?.permalinkTemplate) return '';
76+
if (!this.state.copyLayout && permalink === this.props.layout?.permalinkTemplate) return '';
7777

78-
const isPermalinkNotDefined = !(await this.layoutService.getLayoutByPermalinkTemplate(permalink)) && !reservedPermalinks.includes(permalink);
78+
const isPermalinkNotDefined = permalink ? !(await this.layoutService.getLayoutByPermalinkTemplate(permalink)) : true && !reservedPermalinks.includes(permalink);
7979
const errorMessage = validateField(UNIQUE_REQUIRED, permalink, isPermalinkNotDefined);
8080

8181
return errorMessage;
@@ -95,7 +95,7 @@ export class PageLayoutDetailsModal extends React.Component<PageLayoutModalProps
9595
copyLayout = async (): Promise<void> => {
9696
this.setState({ copyLayout: true, layout: {
9797
...this.state.layout,
98-
permalinkTemplate: null,
98+
permalinkTemplate: this.state.layout.permalinkTemplate + '-copy',
9999
title: this.state.layout.title + ' (copy)'
100100
}});
101101
}

0 commit comments

Comments
 (0)