Skip to content

Commit bbc3495

Browse files
authored
Fixed management API version mismatch (#2385)
* Fixed management API version mismatch * Changed test settings to use the new endpoint * Changed test data jsons
1 parent a92f976 commit bbc3495

File tree

3 files changed

+31
-23
lines changed

3 files changed

+31
-23
lines changed

src/services/tenantService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ export class TenantService {
1111
* Returns tenant settings.
1212
*/
1313
public async getSettings(): Promise<TenantSettings> {
14-
const result = await this.mapiClient.get("/tenant/settings?api-version=2019-12-01", [await this.mapiClient.getPortalHeader("getSettings")]);
15-
return result && result["settings"];
14+
const result = await this.mapiClient.get("/settings/public", [await this.mapiClient.getPortalHeader("getSettings")]);
15+
return result && result["properties"] && result["properties"]["settings"];
1616
}
1717

1818
/**

tests/mocks/defaultStaticData.json

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,7 @@
15621562
"count": 1
15631563
}
15641564
},
1565-
"https://contoso.management.azure-api.net/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/tenant/settings": {
1565+
"https://contoso.management.azure-api.net/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/settings/public": {
15661566
"headers": [
15671567
{
15681568
"name": "content-type",
@@ -1572,16 +1572,20 @@
15721572
"statusCode": 200,
15731573
"statusText": "OK",
15741574
"body": {
1575-
"id": "/settings/public",
1576-
"settings": {
1577-
"CustomPortalSettings.UserRegistrationTerms": "",
1578-
"CustomPortalSettings.UserRegistrationTermsEnabled": "False",
1579-
"CustomPortalSettings.UserRegistrationTermsConsentRequired": "False",
1580-
"CustomPortalSettings.DelegationEnabled": "False",
1581-
"CustomPortalSettings.DelegationUrl": "",
1582-
"CustomPortalSettings.DelegatedSubscriptionEnabled": "False",
1583-
"CustomPortalSettings.RequireUserSigninEnabled": "True"
1584-
}
1575+
"id": "/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/settings/public",
1576+
"type": "Microsoft.ApiManagement/service/settings",
1577+
"name": "public",
1578+
"properties": {
1579+
"settings": {
1580+
"CustomPortalSettings.UserRegistrationTerms": "",
1581+
"CustomPortalSettings.UserRegistrationTermsEnabled": "False",
1582+
"CustomPortalSettings.UserRegistrationTermsConsentRequired": "False",
1583+
"CustomPortalSettings.DelegationEnabled": "False",
1584+
"CustomPortalSettings.DelegationUrl": "",
1585+
"CustomPortalSettings.DelegatedSubscriptionEnabled": "False",
1586+
"CustomPortalSettings.RequireUserSigninEnabled": "True"
1587+
}
1588+
}
15851589
}
15861590
},
15871591
"https://contoso.management.azure-api.net/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/products/unlimited": {

tests/mocks/mockServerData.json

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,18 +93,22 @@
9393
"count": 0
9494
}
9595
},
96-
"/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/tenant/settings":{
96+
"/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/settings/public":{
9797
"statusCode": 200,
9898
"body": {
99-
100-
"id": "/settings/public",
101-
"settings": {
102-
"CustomPortalSettings.UserRegistrationTerms": null,
103-
"CustomPortalSettings.UserRegistrationTermsEnabled": "False",
104-
"CustomPortalSettings.UserRegistrationTermsConsentRequired": "False",
105-
"CustomPortalSettings.DelegationEnabled": "False",
106-
"CustomPortalSettings.DelegationUrl": "",
107-
"CustomPortalSettings.DelegatedSubscriptionEnabled": "False"
99+
"id": "/subscriptions/sid/resourceGroups/rgid/providers/Microsoft.ApiManagement/service/sid/settings/public",
100+
"type": "Microsoft.ApiManagement/service/settings",
101+
"name": "public",
102+
"properties": {
103+
"settings": {
104+
"CustomPortalSettings.UserRegistrationTerms": "",
105+
"CustomPortalSettings.UserRegistrationTermsEnabled": "False",
106+
"CustomPortalSettings.UserRegistrationTermsConsentRequired": "False",
107+
"CustomPortalSettings.DelegationEnabled": "False",
108+
"CustomPortalSettings.DelegationUrl": "",
109+
"CustomPortalSettings.DelegatedSubscriptionEnabled": "False",
110+
"CustomPortalSettings.RequireUserSigninEnabled": "True"
111+
}
108112
}
109113
}
110114
},

0 commit comments

Comments
 (0)