Skip to content

Commit 9d96c0a

Browse files
authored
Removed duplicated ids for group by tag (#1883)
1 parent 2f351a2 commit 9d96c0a

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

src/components/apis/list-of-apis/ko/runtime/api-list-tiles.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<div class="form-inline max-w-500">
22
<div class="d-block flex-grow">
3-
<input type="search" class="form-control form-control-light" aria-label="Search APIs" placeholder="Search APIs" spellcheck="false"
4-
data-bind="textInput: pattern" />
3+
<input type="search" class="form-control form-control-light" aria-label="Search APIs" placeholder="Search APIs"
4+
spellcheck="false" data-bind="textInput: pattern" />
55
<tag-input params="{ scope: 'apis', onChange: onTagsChange }"></tag-input>
66
</div>
77
<div class="form-group ml-auto">
8-
<label for="groupByTag">Group by tag
8+
<label>Group by tag
99
<div class="switch">
10-
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
10+
<input type="checkbox" data-bind="checked: $component.groupByTag">
1111
<span class="slider round"></span>
1212
</div>
1313
</label>

src/components/apis/list-of-apis/ko/runtime/api-list.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
<tag-input params="{ scope: 'apis', onChange: onTagsChange }"></tag-input>
66
</div>
77
<div class="form-group ml-auto">
8-
<label for="groupByTag">Group by tag
8+
<label>Group by tag
99
<div class="switch">
10-
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
10+
<input type="checkbox" data-bind="checked: $component.groupByTag">
1111
<span class="slider round"></span>
1212
</div>
1313
</label>

src/components/operations/operation-list/ko/runtime/operation-list.html

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
<tag-input params="{ scope: $component.tagScope, onChange: onTagsChange }"></tag-input>
2626
</div>
2727
<div class="form-group ml-auto">
28-
<label for="groupByTag">Group by tag
28+
<label>Group by tag
2929
<div class="switch">
30-
<input id="groupByTag" type="checkbox" data-bind="checked: $component.groupByTag">
30+
<input type="checkbox" data-bind="checked: $component.groupByTag">
3131
<span class="slider round"></span>
3232
</div>
3333
</label>
@@ -61,9 +61,11 @@
6161
</div>
6262
<div class="list">
6363
<!-- ko foreach: { data: group.items, as: 'item' } -->
64-
<div role="option" class="list-item table-preset-operations" data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
64+
<div role="option" class="list-item table-preset-operations"
65+
data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
6566
<div class="http-method" data-bind="attr: { 'data-method': method }"></div>
66-
<div data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
67+
<div
68+
data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
6769
</div>
6870
</div>
6971
<!-- /ko -->
@@ -97,7 +99,9 @@
9799
<div role="option" class="list-item table-preset-operations"
98100
data-bind="activate: $component.selectOperation, css: { 'selected': $component.selectedOperationName() === item.name }">
99101
<div class="http-method" data-bind="attr: { 'data-method': method }"></div>
100-
<div data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }"></div>
102+
<div
103+
data-bind="text: ($component.showUrlPath() ? item.urlTemplate : item.displayName), css: { 'text-truncate': !$component.wrapText(), 'text-wrap': $component.wrapText() }, attr: { title: ($component.showUrlPath() ? item.urlTemplate : item.displayName) }">
104+
</div>
101105
</div>
102106
<!-- /ko -->
103107
</div>

0 commit comments

Comments
 (0)