Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReceiverLink Async versions of Complete/Modify/Accept/Reject/Release? #408

Open
Strifex opened this issue Mar 31, 2020 · 5 comments
Open

Comments

@Strifex
Copy link

Strifex commented Mar 31, 2020

Just curious why there aren't Async versions of acknowledgements back to the broker - I see that calling Complete or Accept/Reject/Release/Modify on the ReceiverLink all return void and run synchronously - but I would think since its sending an acknowledgement back to the broker that it would be I/O driven and therefore should have an async option, no? It feels strange that you can async read messages from the receiver link but you can only respond to them synchronously....

Are there any plans for adding async versions of these responses?

@Havret
Copy link
Contributor

Havret commented Apr 2, 2020

This should answer your question --> #367 (comment)

@xinchen10
Copy link
Member

In a future version we will add a UpdateAsync(Message message, DeliveryState state) method. It will wait for the ack from the broker.

@Havret
Copy link
Contributor

Havret commented Apr 21, 2020

@xinchen10 do you think I can submit PR?

@xinchen10
Copy link
Member

@Havret if you refer to the new UpdateAsync API, yes definitely.

@Havret
Copy link
Contributor

Havret commented May 11, 2020

I gave it a try, but apparently ActiveMQ Artemis doesn't support this mode. :( http://activemq.2283324.n4.nabble.com/Artemis-AMQP-Acknowledge-confirmation-td4756837.html#a4756868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants