Skip to content

Commit b93b002

Browse files
DanielleCogsDanielle Cogburn
and
Danielle Cogburn
authored
Fix(Designer): Action card tooltip now read with screen reader (#4138)
* added aria-labelledby for searchable dropdown * PR comment * focus returns to search button * trigger tooltip works with nvda --------- Co-authored-by: Danielle Cogburn <dacogburn@microsoft.com>
1 parent e56a6ca commit b93b002

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

.github/sync_config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"Ram-G": "ramgup@microsoft.com",
3131
"Aleks-gdb": "aleksd@microsoft.com",
3232
"rllyy97": "rileyevans@microsoft.com",
33-
"refortie":"refortie@microsoft.com"
33+
"refortie": "refortie@microsoft.com"
3434
}
3535
}
3636
}

.github/workflows/issue-sync.yml

+10-10
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ on:
1212
manual_trigger:
1313
description: 'Manual Trigger'
1414
required: false
15-
default: "true"
15+
default: 'true'
1616
type: choice
1717
options:
18-
- "true"
19-
- "false"
18+
- 'true'
19+
- 'false'
2020

2121
concurrency:
2222
group: issue-${{ github.event.issue.number }}
@@ -29,10 +29,10 @@ jobs:
2929
issues: write
3030
pull-requests: write
3131
name: Sync workflow
32-
steps:
33-
- uses: actions/checkout@v3
34-
- uses: hartra344/GitSync@main
35-
env:
36-
ado_token: '${{ secrets.ADO_SYNC_TOKEN }}'
37-
github_token: '${{ secrets.GITHUB_TOKEN }}'
38-
config_file: './.github/sync_config.json'
32+
steps:
33+
- uses: actions/checkout@v3
34+
- uses: hartra344/GitSync@main
35+
env:
36+
ado_token: '${{ secrets.ADO_SYNC_TOKEN }}'
37+
github_token: '${{ secrets.GITHUB_TOKEN }}'
38+
config_file: './.github/sync_config.json'

CHANGELOG.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Logic Apps Designer
2-
## [2.111.0](https://github.com/Azure/LogicAppsUX/compare/v2.110.0...v2.111.0) (2024-02-06)
32

3+
## [2.111.0](https://github.com/Azure/LogicAppsUX/compare/v2.110.0...v2.111.0) (2024-02-06)
44

55
### Bug Fixes
66

7-
* **Designer:** Focus returns to search button after closing side panel ([#4126](https://github.com/Azure/LogicAppsUX/issues/4126)) ([95aaccf](https://github.com/Azure/LogicAppsUX/commit/95aaccfa05060a1a5660f5bf497e7df2e3055b0f))
8-
* **designer:** OpenAPI tokens from SharePoint trigger use `triggerOutputs` instead of `triggerBody` ([#4122](https://github.com/Azure/LogicAppsUX/issues/4122)) ([1b54d75](https://github.com/Azure/LogicAppsUX/commit/1b54d752344ca2a1a28d52e71a6ca5c4ba4140b7))
9-
* **vscode:** Parse interpolated connections data as JSON ([#4135](https://github.com/Azure/LogicAppsUX/issues/4135)) ([c855aee](https://github.com/Azure/LogicAppsUX/commit/c855aee8c9a657f01e43e3e34d349dd857f0f7b7))
7+
- **Designer:** Focus returns to search button after closing side panel ([#4126](https://github.com/Azure/LogicAppsUX/issues/4126)) ([95aaccf](https://github.com/Azure/LogicAppsUX/commit/95aaccfa05060a1a5660f5bf497e7df2e3055b0f))
8+
- **designer:** OpenAPI tokens from SharePoint trigger use `triggerOutputs` instead of `triggerBody` ([#4122](https://github.com/Azure/LogicAppsUX/issues/4122)) ([1b54d75](https://github.com/Azure/LogicAppsUX/commit/1b54d752344ca2a1a28d52e71a6ca5c4ba4140b7))
9+
- **vscode:** Parse interpolated connections data as JSON ([#4135](https://github.com/Azure/LogicAppsUX/issues/4135)) ([c855aee](https://github.com/Azure/LogicAppsUX/commit/c855aee8c9a657f01e43e3e34d349dd857f0f7b7))
1010

1111
## [2.110.0](https://github.com/Azure/LogicAppsUX/compare/v2.109.0...v2.110.0) (2024-02-05)
1212

libs/designer-ui/src/lib/card/addActionCard/index.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,11 @@ export const AddActionCard: React.FC<AddActionCardProps> = ({ addCardType, onCli
7878

7979
const tooltipHeading = addCardType === ADD_CARD_TYPE.TRIGGER ? triggerTooltipHeading : actionTooltipHeading;
8080
const tooltipBody = addCardType === ADD_CARD_TYPE.TRIGGER ? triggerTooltipBody : actionTooltipBody;
81+
const tooltipId = `placeholder-node-${addCardType}`;
8182

8283
return (
8384
<TooltipHost
84-
id={`placeholder-node-${addCardType}`}
85+
id={tooltipId}
8586
delay={0}
8687
directionalHint={DirectionalHint.rightCenter}
8788
calloutProps={{ gapSpace: 8 }}
@@ -96,6 +97,7 @@ export const AddActionCard: React.FC<AddActionCardProps> = ({ addCardType, onCli
9697
>
9798
<div style={{ position: 'relative' }}>
9899
<div
100+
aria-describedby={tooltipId}
99101
aria-label={title}
100102
className={css('msla-panel-card-container', selected && 'msla-panel-card-container-selected')}
101103
style={getCardStyle(brandColor)}

0 commit comments

Comments
 (0)