Add Feature Management schema #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
zhenlan,
jimmyca15,
amerjusupovic and
mrm9084
jimmyca15
reviewed
Feb 8, 2024
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://azconfig.io/schemas/FeatureManagement/v1.0.0/FeatureManagement.json", | ||
| "type": "object", | ||
| "title": "An Azure App Configuration Feature Management Configuration", |
There was a problem hiding this comment.
I would say this is Microsoft Feature Management schema.
The schema that describes individual flag is the Microsoft Feature Flag Schema.
There was a problem hiding this comment.
I like the idea naming this schema as Microsoft Feature Management.
@zhenlan
As discussed in the email thread, snake_casing will be used:
"feature_management": {
"feature_flags": [
{
// Microsoft feature flag schema
}
]
}
rossgrambo
reviewed
Feb 16, 2024
| "title": "Feature Flags", | ||
| "description": "Declares feature flags based on Microsoft Feature Flag schema.", | ||
| "items": { | ||
| "$ref": "http://azconfig.io/schemas/FeatureManagement/v1.1.0/FeatureFlag.json" |
There was a problem hiding this comment.
$ref should be the uri of the file rather than the $id. I believe ./FeatureFlag.v1.1.0.schema.json would work, but to make it work without folder context- I think we should do: https://github.com/Azure/AppConfiguration/blob/main/docs/FeatureManagement/FeatureFlag.v1.1.0.schema.json
RichardChen820
approved these changes
Feb 20, 2024
Eskibear
approved these changes
Feb 20, 2024
zhiyuanliang-ms
commented
Feb 20, 2024
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://azconfig.io/schemas/FeatureManagement/v1.0.0/FeatureManagement.json", | ||
| "type": "object", | ||
| "title": "A Microsoft Feature Management Configuration", |
There was a problem hiding this comment.
Suggested change
| "title": "A Microsoft Feature Management Configuration", | |
| "title": "The Microsoft Feature Management Schema", |
jimmyca15
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature management schema will be provided by the Kubernetes provider and it would be recognized by client Feature Management libraries. It would be better to place the schema in the App Config repo instead of the Feature Management repo, as discussed here