Skip to content

Merge main to release/preview/v1 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 21, 2024
Merged

Merge main to release/preview/v1 #50

merged 17 commits into from
Mar 21, 2024

Conversation

Eskibear
Copy link
Member

No description provided.

@avanigupta
Copy link
Member

Reminder to merge this PR with a merge commit since we should preserve all feature commits in the release branch.

@Eskibear
Copy link
Member Author

Eskibear commented Mar 20, 2024

I just revisited our public docs, and find there is usage of has(key) in sample code, which I think is valid.
But other public method of ReadonlyMap was removed when I changed it to impl IGettable. That would also break the use case. So, I would like to change it back to also impl ReadonlyMap which is compatible with interface IGettable. And it would not affect what we've done for FM lib.

@Eskibear Eskibear merged commit f86cad2 into release/preview/v1 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants