-
Notifications
You must be signed in to change notification settings - Fork 2
Support tag filter #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support tag filter #188
Conversation
…avaScriptProvider into zhiyuanliang/select-snapshot
Merge main to preview
…avaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
const sortedStringA = [...tagsA].sort().join("\n"); | ||
const sortedStringB = [...tagsB].sort().join("\n"); | ||
|
||
return sortedStringA === sortedStringB; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this check robust? \n
is not allowed in tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed .NET provider's implementation: https://github.com/Azure/AppConfiguration-DotnetProvider/pull/637/files#diff-5f9d810c153f73ab4382bfddf40b76b7c30bba39beae6e74557bc078115f3f95
I checked out backend code, we don't forbid \n
but the portal will not allow you to enter \n
when creating a tag.
…ScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/tag-filter
…ScriptProvider into zhiyuanliang/tag-filter
Usage