-
Notifications
You must be signed in to change notification settings - Fork 2
Merge main to preview #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * populate feature flag id * fix lint * populate only when telemetry is enabled * add testcase * fix lint * update * use window.btoa * rename method * revert add window.
* update to ETag * revert change
* Adds additional undefined check (#104) * add loadCdn * revert change * fix lint * update to loadFromCdn & reuse load method * update * update * add js file extension to imports (#109) * update typescript version (#112) * add requestTracingOptions (#114) * Version bump 1.1.1 (#115) * bump up version 1.1.1 * update --------- Co-authored-by: Ross Grambo <rossgrambo@microsoft.com> Co-authored-by: linglingye001 <143174321+linglingye001@users.noreply.github.com>
Merge main to preview
…ScriptProvider into zhiyuanliang/merge-main-to-preview
Merge main to preview
This reverts commit 6dae81a.
This reverts commit 7503688.
Revert loadFromCdn
Add AllocationId to telemetry metadata
* resolve conflicts * resolve conflicts * resolve conflicts * add tests * resolve conflicts and update * fix lint * resolve conflicts * resolve comments * update package-lock * update * update * update failover error * update * update * update failoverable error with 'ENOTFOUND' * fix lint * update * added ENOENT error * update * update error message in test * update test * update test * update * resolve conflicts
* load balance support * improve test
Merge main to preview
Add replica count tracing
Merge main to preview
* refresh based on page etag * remove watchAll & reorganize the code * add testcase * fix lint & update method name * add comment * update variable name * move public method * add more comments * fix lint * resolve merge conflict
…ScriptProvider into merge-main-to-preview
Merge main to preview
* add fm package version tracing * update comment * update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (15)
- package.json: Language not supported
- test/keyvault.test.ts: Evaluated as low risk
- src/refresh/RefreshTimer.ts: Evaluated as low risk
- test/clientOptions.test.ts: Evaluated as low risk
- test/json.test.ts: Evaluated as low risk
- src/RefreshOptions.ts: Evaluated as low risk
- src/load.ts: Evaluated as low risk
- src/featureManagement/FeatureFlagOptions.ts: Evaluated as low risk
- .github/workflows/ci.yml: Evaluated as low risk
- src/AzureAppConfigurationOptions.ts: Evaluated as low risk
- rollup.config.mjs: Evaluated as low risk
- src/requestTracing/constants.ts: Evaluated as low risk
- src/requestTracing/utils.ts: Evaluated as low risk
- src/featureManagement/constants.ts: Evaluated as low risk
- src/version.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/common/utils.ts:13
- The jsonSorter function may not handle nested objects and arrays correctly. Ensure that nested objects and arrays are sorted properly.
export function jsonSorter(key, value) {
linglingye001
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.