Add feature management package version tracing #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
Eskibear,
jimmyca15,
linglingye001 and
Copilot
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/AzureAppConfigurationImpl.ts:332
- Ensure that 'VERSION' is a valid property of the imported package. If it is not, this could lead to unexpected behavior.
this.#fmVersion = fmPackage?.VERSION;
src/AzureAppConfigurationImpl.ts:326
- [nitpick] Consider renaming '#isPackageInspected' to '#isFmPackageInspected' for better clarity and consistency.
async #ensurePackageInspected() {
zhiyuanliang-ms
commented
Jan 15, 2025
|
@jimmyca15 @Linglingye @zhenlan @rossgrambo @mrm9084 @juniwang I want to merge this PR before we stablize v2. Could you help review this PR please? |
linglingye001
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Collect JS FM package version usage in request tracing
Note that there is an exported constant
VERSIONin JS FM package. This is by design to be a hook for us to know the package version.