Skip to content

Commit b1cf809

Browse files
committed
reset timer on 304, maintain refresh interval gap between attempts
1 parent fb56a0f commit b1cf809

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/AzureAppConfigurationImpl.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -411,16 +411,15 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
411411
if (needRefresh) {
412412
try {
413413
await this.#loadSelectedAndWatchedKeyValues();
414-
this.#refreshTimer.reset();
415414
} catch (error) {
416415
// if refresh failed, backoff
417416
this.#refreshTimer.backoff();
418417
throw error;
419418
}
420-
return Promise.resolve(true);
421419
}
422420

423-
return Promise.resolve(false);
421+
this.#refreshTimer.reset();
422+
return Promise.resolve(needRefresh);
424423
}
425424

426425
/**
@@ -462,16 +461,15 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
462461
if (needRefresh) {
463462
try {
464463
await this.#loadFeatureFlags();
465-
this.#featureFlagRefreshTimer.reset();
466464
} catch (error) {
467465
// if refresh failed, backoff
468466
this.#featureFlagRefreshTimer.backoff();
469467
throw error;
470468
}
471-
return Promise.resolve(true);
472469
}
473470

474-
return Promise.resolve(false);
471+
this.#featureFlagRefreshTimer.reset();
472+
return Promise.resolve(needRefresh);
475473
}
476474

477475
onRefresh(listener: () => any, thisArg?: any): Disposable {

0 commit comments

Comments
 (0)