Skip to content

Commit 38c6577

Browse files
committed
Rename toHierarchicalData to constructConfigurationObject
1 parent 35adc57 commit 38c6577

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/AzureAppConfiguration.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ export type AzureAppConfiguration = {
1616
* @param thisArg - Optional. Value to use as `this` when executing callback.
1717
*/
1818
onRefresh(listener: () => any, thisArg?: any): Disposable;
19-
} & IGettable & IHierarchicalData;
19+
} & IGettable & IConfigurationObject;
2020

21-
interface IHierarchicalData {
21+
interface IConfigurationObject {
2222
/**
23-
* Convert the Map-styled data structure to hierarchical object properties.
23+
* Construct configuration object based on Map-styled data structure and hierarchical keys.
2424
* @param options - The options to control the conversion behavior.
2525
*/
26-
toHierarchicalData(options?: HierarchicalDataConversionOptions): Record<string, any>;
26+
constructConfigurationObject(options?: ConfigurationObjectConstructionOptions): Record<string, any>;
2727
}
2828

29-
export interface HierarchicalDataConversionOptions {
29+
export interface ConfigurationObjectConstructionOptions {
3030
/**
3131
* The separator to use when converting hierarchical keys to object properties.
3232
* Default is '.'.

src/AzureAppConfigurationImpl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import { AppConfigurationClient, ConfigurationSetting, ConfigurationSettingId, GetConfigurationSettingOptions, GetConfigurationSettingResponse, ListConfigurationSettingsOptions } from "@azure/app-configuration";
55
import { RestError } from "@azure/core-rest-pipeline";
6-
import { AzureAppConfiguration, HierarchicalDataConversionOptions } from "./AzureAppConfiguration";
6+
import { AzureAppConfiguration, ConfigurationObjectConstructionOptions } from "./AzureAppConfiguration";
77
import { AzureAppConfigurationOptions } from "./AzureAppConfigurationOptions";
88
import { IKeyValueAdapter } from "./IKeyValueAdapter";
99
import { JsonKeyValueAdapter } from "./JsonKeyValueAdapter";
@@ -182,7 +182,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
182182
/**
183183
* Construct hierarchical data object from map.
184184
*/
185-
toHierarchicalData(options?: HierarchicalDataConversionOptions): Record<string, any> {
185+
constructConfigurationObject(options?: ConfigurationObjectConstructionOptions): Record<string, any> {
186186
const separator = options?.separator ?? ".";
187187
const prefix = options?.prefix ?? "";
188188
const onError = options?.onError ?? "error";

test/load.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ describe("load", function () {
185185
}]
186186
});
187187
expect(settings).not.undefined;
188-
const data = settings.toHierarchicalData();
188+
const data = settings.constructConfigurationObject();
189189
expect(data).not.undefined;
190190
expect(data.app.settings.fontColor).eq("red");
191191
expect(data.app.settings.fontSize).eq("40");
@@ -199,7 +199,7 @@ describe("load", function () {
199199
}]
200200
});
201201
expect(settings).not.undefined;
202-
const data = settings.toHierarchicalData();
202+
const data = settings.constructConfigurationObject();
203203
expect(data).not.undefined;
204204
expect(data.app2.settings.fontColor).eq("blue");
205205
expect(data.app2.settings.fontSize).eq(20);
@@ -238,7 +238,7 @@ describe("load", function () {
238238
expect(settings.get("app3.settings")).eq("placeholder");
239239
expect(settings.get("app3.settings.fontColor")).eq("yellow");
240240
// use data property
241-
const data = settings.toHierarchicalData({ onError: "ignore" }); // ignore error on hierarchical key conversion
241+
const data = settings.constructConfigurationObject({ onError: "ignore" }); // ignore error on hierarchical key conversion
242242
expect(data.app3.settings).not.eq("placeholder"); // not as expected.
243243
expect(data.app3.settings.fontColor).eq("yellow");
244244
});
@@ -252,7 +252,7 @@ describe("load", function () {
252252
});
253253
expect(settings).not.undefined;
254254
expect(() => {
255-
settings.toHierarchicalData();
255+
settings.constructConfigurationObject();
256256
}).to.throw("The key 'app3.settings' is not a valid path.");
257257
});
258258
});

0 commit comments

Comments
 (0)