Fix build warning #561
Merged
Fix build warning #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanigupta
approved these changes
Jun 21, 2024
amerjusupovic
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Currently, there are NETSDK1210 and xunit1031 warnings while building .NET provider projects.
For xunit1031 warnings, I had a previous PR #557 which tried to fix it. But somehow I missed something and didn't resolve all the warnings. In this PR, I resolved the remaining warnings.
For NETSDK1210, this is because we have
<IsAotCompatible>true</IsAotCompatible>property inMicrosoft.Extensions.Configuration.AzureAppConfiguration.csproj. But AOT is only available for .NET 7+. ref Currenly, we are targeting on netstandard.To suppress the NETSDK1210 warning, we need to add condition for this property.