Deprecate and rename refresh APIs for clarity #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerjusupovic
changed the title
amerjusupovic
changed the title
Eskibear
reviewed
Mar 14, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
Eskibear
reviewed
Mar 14, 2024
...osoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlagOptions.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Mar 14, 2024
...rosoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationRefreshOptions.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Mar 14, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/RefreshConstants.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Mar 14, 2024
...osoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlagOptions.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Apr 3, 2024
...rosoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationRefreshOptions.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Apr 3, 2024
| @@ -27,7 +38,26 @@ public class FeatureFlagOptions | |||
| /// <summary> | |||
| /// The time after which the cached values of the feature flags expire. Must be greater than or equal to 1 second. | |||
| /// </summary> | |||
| public TimeSpan CacheExpirationInterval { get; set; } = RefreshConstants.DefaultFeatureFlagsCacheExpirationInterval; | |||
| [Obsolete("The CacheExpirationInterval property will be deprecated in a future release. Please use the new `SetFeatureFlagRefreshInterval` method instead. " + | |||
There was a problem hiding this comment.
Method has been renamed to SetRefreshInterval
There was a problem hiding this comment.
Can we use nameof(SetRefreshInterval) to avoid errors like this in future?
There was a problem hiding this comment.
property will be deprecated in a future release
Probably just terminology, but it sounds like the API is still not deprecated. How do you like this?
... property is deprecated and will be removed in a future release...
amerjusupovic
force-pushed
the
ajusupovic/rename-refresh-apis
branch
2 times, most recently
from
54a4061 to
4fa92eb
Compare
avanigupta
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #350