Skip to content

Commit 40768ff

Browse files
Include discovered replicas in replica count for request tracing (#613)
* count total clients from client manager for replica count * set replica count whenevr calling getclients
1 parent a544fd0 commit 40768ff

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,11 @@ public async Task RefreshAsync(CancellationToken cancellationToken)
208208

209209
IEnumerable<ConfigurationClient> clients = _configClientManager.GetClients();
210210

211+
if (_requestTracingOptions != null)
212+
{
213+
_requestTracingOptions.ReplicaCount = clients.Count() - 1;
214+
}
215+
211216
//
212217
// Filter clients based on their backoff status
213218
clients = clients.Where(client =>
@@ -612,6 +617,11 @@ private async Task LoadAsync(bool ignoreFailures, CancellationToken cancellation
612617
{
613618
IEnumerable<ConfigurationClient> clients = _configClientManager.GetClients();
614619

620+
if (_requestTracingOptions != null)
621+
{
622+
_requestTracingOptions.ReplicaCount = clients.Count() - 1;
623+
}
624+
615625
if (await TryInitializeAsync(clients, startupExceptions, cancellationToken).ConfigureAwait(false))
616626
{
617627
break;
@@ -966,7 +976,6 @@ private void SetRequestTracingOptions()
966976
IsDevEnvironment = TracingUtils.IsDevEnvironment(),
967977
IsKeyVaultConfigured = _options.IsKeyVaultConfigured,
968978
IsKeyVaultRefreshConfigured = _options.IsKeyVaultRefreshConfigured,
969-
ReplicaCount = _options.Endpoints?.Count() - 1 ?? _options.ConnectionStrings?.Count() - 1 ?? 0,
970979
FeatureFlagTracing = _options.FeatureFlagTracing,
971980
IsLoadBalancingEnabled = _options.LoadBalancingEnabled
972981
};

0 commit comments

Comments
 (0)