Fixing subscription values (#34)

# Pull Request

## Issue

Fixes #33 
Fixes #32

## Description

Changes to ensure that subscription ids persist as an array when only
one value remains.
Handling case insensitive deduplication of subscription ids.
Fixes a part of the ReadMe.md (probably more work required, but fixing a
small part of that document)

## License

By submitting this pull request, I confirm that my contribution is made
under the terms of the projects associated license.

Author: lovelysandwich

README.md

@@ -6,21 +6,21 @@
 
 ## Synopsis
 
-This is a PowerShell module that provides a set of cmdlets to manage Azure Landing Zones.
+This is a PowerShell module that provides a set of cmdlets to create and manage Azure Landing Zones.
 
 ## Description
 
-This module provides a set of cmdlets to manage Azure Landing Zones.
+This module provides a set of cmdlets to create and manage Azure Landing Zones.
 
 ## Why
 
-The goal of this project it is to make easy to get started with Azure Landing Zones and to speed up some basic tasks that you would be using while managing your Azure Landing Zones.
+The goal of this project it is to make easy to get started with Azure Landing Zones and to speed up some basic tasks that you would need to perform whilst managing your Azure Landing Zones.
 
 ## Getting Started
 
 ### Prerequisites
 
-In order to use this module you will need powershell 7.1 or higher.
+In order to use this module you will need PowerShell 7.1 or higher.
 
 ### Installation
 
@@ -32,24 +32,31 @@ Install-Module -Name ALZ
 
 ### Quick start
 
-Before start o utilize the functionality of the module you can verify if you have all the prerequisites installed, with the built in command:
+Before you start you can utilize the functionality of the module to verify if you have all the prerequisites installed with the built in command:
 
 ```powershell
-Test-ALZPrerequisites
+Test-ALZRequirement
 ```
 
-#### Create a new Azure Landing Zone Environment
+Currently this tests for:
 
-```powershell
+* Supported minimum PowerShell version
+* Azure PowerShell Module
+* Git
+* Azure CLI
+* Bicep
 
+#### Create a new Azure Landing Zone Environment
 
+```powershell
+New-ALZEnvironment -o <output_directory>
 ```
 
 ## Development
 
-### Prerequisites
+### Development Prerequisites
 
-In order to develop this module you will need powershell 7.1 or higher.
+In order to develop this module you will need PowerShell 7.1 or higher.
 
 ### Commands to install a build locally
 
@@ -61,22 +68,16 @@ Import-Module .\src\Artifacts\ALZ.psd1 -Force
 
 ## Contributing
 
-This project welcomes contributions and suggestions.  Most contributions require you to agree to a
-Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us
+This project welcomes contributions and suggestions.  Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us
 the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.
 
-When you submit a pull request, a CLA bot will automatically determine whether you need to provide
-a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions
-provided by the bot. You will only need to do this once across all repos using our CLA.
+When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/).
-For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or
-contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
+For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
 
 ## Trademarks
 
-This project may contain trademarks or logos for projects, products, or services. Authorized use of Microsoft
-trademarks or logos is subject to and must follow
-[Microsoft's Trademark & Brand Guidelines](https://www.microsoft.com/en-us/legal/intellectualproperty/trademarks/usage/general).
+This project may contain trademarks or logos for projects, products, or services. Authorized use of Microsoft trademarks or logos is subject to and must follow [Microsoft's Trademark & Brand Guidelines](https://www.microsoft.com/en-us/legal/intellectualproperty/trademarks/usage/general).
 Use of Microsoft trademarks or logos in modified versions of this project must not cause confusion or imply Microsoft sponsorship.
-Any use of third-party trademarks or logos are subject to those third-party's policies.
+Any use of third-party trademarks or logos are subject to those third-party's policies.

src/ALZ/Assets/alz-bicep-config/v0.14.1-pre.config.json

@@ -340,7 +340,7 @@
         },
         "AllSubscriptionIds": {
             "Type": "Computed",
-            "Process": "@($args | Select-Object -Unique)",
+            "Process": "@($args | ForEach-Object { $_.ToLower() } | Select-Object -Unique)",
             "Value": [
                 "{%ManagementSubscriptionId%}",
                 "{%ConnectivitySubscriptionId%}",

src/ALZ/Private/Edit-ALZConfigurationFilesInPlace.ps1

@@ -71,6 +71,7 @@ function Edit-ALZConfigurationFilesInPlace {
                             if ($null -ne $configKey.Value.Process) {
                                 $scriptBlock = [ScriptBlock]::Create($configKey.Value.Process)
                                 $formattedValues = Invoke-Command -ScriptBlock $scriptBlock -ArgumentList $formattedValues
+                                $formattedValues = @($formattedValues)
                             }
 
                             $bicepConfigNode[$leafPropertyName] = $formattedValues

src/Tests/Unit/Private/Edit-ALZConfigurationFilesInPlace.Tests.ps1

@@ -531,6 +531,103 @@ InModuleScope 'ALZ' {
                     -Scope It
             }
 
+            It 'Computed, Processed array values replace values correctly in a case insensitive deduplication.' {
+                $config = [pscustomobject]@{
+                    Nested     = [pscustomobject]@{
+                        Type        = "Computed"
+                        Description = "A Test Value"
+                        Process = '@($args | ForEach-Object { $_.ToLower() } | Select-Object -Unique)'
+                        Value   = @(
+                            "A",
+                            "a",
+                            "A",
+                            "a"
+                        )
+                        Targets     = @(
+                            [pscustomobject]@{
+                                Name        = "parValue.value"
+                                Destination = "Parameters"
+                            })
+                    }
+                }
+
+                $fileContent = '{
+                    "parameters": {
+                        "parValue": {
+                            "value": []
+                        }
+                    }
+                }'
+
+                $expectedContent = '{
+                    "parameters": {
+                        "parValue": {
+                            "value": [ "a" ]
+                        }
+                    }
+                }'
+
+                Mock -CommandName Get-Content -ParameterFilter { $Path -eq $testFile1Name } -MockWith {
+                    $fileContent
+                }
+
+                $expectedContent = Format-ExpectedResult -expectedJson $expectedContent
+
+                Edit-ALZConfigurationFilesInPlace  -alzEnvironmentDestination '.' -configuration $config
+
+                Should -Invoke -CommandName Out-File `
+                    -ParameterFilter { $FilePath -eq $testFile1Name -and $InputObject -eq $expectedContent } `
+                    -Scope It
+            }
+
+            It 'Computed, Processed array values replace values correctly and keep array type when only one item remains.' {
+                $config = [pscustomobject]@{
+                    Nested     = [pscustomobject]@{
+                        Type        = "Computed"
+                        Description = "A Test Value"
+                        Process = '@($args | Select-Object -Unique)'
+                        Value   = @(
+                            "1",
+                            "1",
+                            "1"
+                        )
+                        Targets     = @(
+                            [pscustomobject]@{
+                                Name        = "parValue.value"
+                                Destination = "Parameters"
+                            })
+                    }
+                }
+
+                $fileContent = '{
+                    "parameters": {
+                        "parValue": {
+                            "value": []
+                        }
+                    }
+                }'
+
+                $expectedContent = '{
+                    "parameters": {
+                        "parValue": {
+                            "value": [ "1" ]
+                        }
+                    }
+                }'
+
+                Mock -CommandName Get-Content -ParameterFilter { $Path -eq $testFile1Name } -MockWith {
+                    $fileContent
+                }
+
+                $expectedContent = Format-ExpectedResult -expectedJson $expectedContent
+
+                Edit-ALZConfigurationFilesInPlace  -alzEnvironmentDestination '.' -configuration $config
+
+                Should -Invoke -CommandName Out-File `
+                    -ParameterFilter { $FilePath -eq $testFile1Name -and $InputObject -eq $expectedContent } `
+                    -Scope It
+            }
+
             It 'Computed, Processed values replace values correctly' {
                 $config = [pscustomobject]@{
                     Nested     = [pscustomobject]@{