Skip to content

Update requirements.txt #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

msangapu-msft
Copy link
Contributor

This sample is currently breaking our quickstart. This is a version bump and adding Werkzeug==2.2.2 to fix the sample.

@msangapu-msft
Copy link
Contributor Author

#sign-off

@msangapu-msft
Copy link
Contributor Author

@vmagelo I'm a writer for App Service and we need to update requirements.txt as the current quickstart scenario is broken due to this.

Copy link

@charris-msft charris-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to have @bobtabor-msft take a look too.

@bobtabor-msft
Copy link
Contributor

I was able to test this PR in a GitHub Codespace and it all seemed to work. I did not try to deploy to Azure from the GitHub Codespace, however.

@msangapu-msft
Copy link
Contributor Author

msangapu-msft commented Dec 15, 2023 via email

@bobtabor-msft
Copy link
Contributor

@msangapu-msft I think Chris is out for the rest of the year. I'll merge.

@bobtabor-msft bobtabor-msft merged commit 223b3cf into Azure-Samples:main Dec 15, 2023
@msangapu-msft
Copy link
Contributor Author

msangapu-msft commented Dec 15, 2023

@msangapu-msft I think Chris is out for the rest of the year. I'll merge.

@bobtabor-msft Thank you for merging. Could you please add Cephas and I as admins to the repo?

Tully22 pushed a commit to Tully22/msdocs-python-flask-webapp-quickstart that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants