This repository was archived by the owner on Feb 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Change cosoms sample from track1 to track2(Azure CosmosDB sample forhigh availability) #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…high availability.)
jongio
suggested changes
Jul 27, 2020
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
@anuchandy - Please review. Thanks, Jon |
@kushagraThapar - could you help review this? |
kushagraThapar
suggested changes
Aug 19, 2020
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
anuchandy
reviewed
Aug 19, 2020
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
@anuchandy- Please review, thanks. |
anuchandy
approved these changes
Aug 24, 2020
conniey
approved these changes
Sep 9, 2020
...a/com/microsoft/azure/management/cosmosdb/samples/CreateCosmosDBWithEventualConsistency.java
Outdated
Show resolved
Hide resolved
conniey
approved these changes
Sep 15, 2020
pom.xml
Outdated
<version>1.9.4</version> | ||
<groupId>com.azure</groupId> | ||
<artifactId>azure-cosmos</artifactId> | ||
<version>4.4.0-beta.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be pointing to a GA version rather than a beta one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cosoms sample from track1 to track2(Only the function related to the package of azure-documentdb has been changed, the function related to MGMT has not been changed. Waiting for the new MGMT SDK for java)