Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and restore “developer settings” from user cookie #1791

Open
cforce opened this issue Jul 7, 2024 · 2 comments
Open

Store and restore “developer settings” from user cookie #1791

cforce opened this issue Jul 7, 2024 · 2 comments
Labels
enhancement New feature or request javascript Pull requests that update Javascript code

Comments

@cforce
Copy link

cforce commented Jul 7, 2024

Allow users to have their personal preference for developer settings but storing cfg to Cookie as persistent state each time it changes and restore on session start (login)

This shall be simply ui side implementation by some js magic - no backend api changes

@pamelafox
Copy link
Collaborator

I think it might be even easier to do this with localStorage. Or at least, I personally prefer using localStorage over cookies, for browser-side preferences. You'd need to think about the situation where backend defaults change though, would the backend administrator want that to override user preferences? And could JS errors became a possibility if the settings types changed?

@pamelafox pamelafox added enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 10, 2024
@cforce
Copy link
Author

cforce commented Jul 10, 2024

Yes, local storage is even better.
Defaults -by reset to default as an option clickable formally settings would leave control to the user.
Downwards compatible api changes is alway a good pattern 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants