Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enforcement of fallback solution #17

Closed
smcvb opened this issue Mar 31, 2020 · 1 comment
Closed

Allow enforcement of fallback solution #17

smcvb opened this issue Mar 31, 2020 · 1 comment
Assignees
@smcvb
Labels
Priority 1: Must Status: Resolved Type: Bug
Milestone
Release 4.3.1

Comments

@smcvb
Copy link
Member

smcvb commented Mar 31, 2020

Currently, the SpringCloudHttpBackupCommandRouter's knowledge of MessageRoutingInformation will only be used if no ServiceInstance metadata is present.

However, through some testing me and @corradom figured out that more recent versions of Eureka support metadata adjustment of the local Registration, but this knowledge is only propagated towards the DiscoveryClient once. Due to this, the global ServiceInstance metadata will be stuck on the command filter DenyAll, making it so that Eureka is currently unusable.

If we can enforce the MessageRoutingInformation from the SpringCloudHttpBackupCommandRouter to be used when such a discrepancy is in place, or if we enforce the usage of MessageRoutingInformation in favor of the ServiceInstance metadata, then we can alleviate this issue.
@smcvb smcvb added this to the Release 4.3.1 milestone Mar 31, 2020
@smcvb smcvb mentioned this issue May 1, 2020
Closed
@smcvb smcvb self-assigned this May 6, 2020
smcvb added a commit that referenced this issue May 6, 2020
@smcvb
Introduce enforce http discovery option
eb10ffc 
The SpringCloudHttpBackupCommandRouter.Builder should allow specifying
the enforcement of http command discovery

#17
smcvb added a commit that referenced this issue May 6, 2020
@smcvb
Introduce enforce http discovery option
c0d269e 
The SpringCloudHttpBackupCommandRouter.Builder should allow specifying
the enforcement of http command discovery

#17
@smcvb smcvb mentioned this issue May 6, 2020
Merged
smcvb added a commit that referenced this issue May 7, 2020
@smcvb
Merge pull request #24 from AxonFramework/feature/17
ab5ab21 
[#17] Allow enforcement of fallback solution
@smcvb
Copy link
Member Author

smcvb commented May 7, 2020

Closing this issue as it has been resolved in pull request #24.

@smcvb smcvb closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smcvb smcvb

Labels
Priority 1: Must Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 4.3.1
Development

No branches or pull requests
1 participant
@smcvb