Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin black to 22.10.0 #1412

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Pin black to 22.10.0 #1412

merged 2 commits into from
Mar 30, 2023

Conversation

marcharper
Copy link
Member

No description provided.

@drvinceknight
Copy link
Member

Eurgh... So this is failing on Windows + python 3.11 (specifically axelrod\strategies\titfortat.py):

Requirement already satisfied: click>=8.0.0 in c:\hostedtoolcache\windows\python\3.11.2\x64\lib\site-packages (from black==22.10.0) (8.1.3)
[11](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:12)
Collecting mypy-extensions>=0.4.3
[12](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:13)
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
[13](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:14)
Collecting pathspec>=0.9.0
[14](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:15)
  Downloading pathspec-0.11.1-py3-none-any.whl (29 kB)
[15](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:16)
Requirement already satisfied: platformdirs>=2 in c:\hostedtoolcache\windows\python\3.11.2\x64\lib\site-packages (from black==22.10.0) (3.1.1)
[16](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:17)
Requirement already satisfied: colorama in c:\hostedtoolcache\windows\python\3.11.2\x64\lib\site-packages (from click>=8.0.0->black==22.10.0) (0.4.6)
[17](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:18)
Installing collected packages: pathspec, mypy-extensions, black
[18](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:19)
Successfully installed black-22.10.0 mypy-extensions-1.0.0 pathspec-0.11.1
[19](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:20)
would reformat axelrod\strategies\titfortat.py
[20](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:21)

[21](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:22)
Oh no! \U0001f4a5 \U0001f494 \U0001f4a5
[22](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:23)
1 file would be reformatted, 185 files would be left unchanged.
[23](https://github.com/Axelrod-Python/Axelrod/actions/runs/4433164270/jobs/7847501543?pr=1412#step:12:24)
Error: Process completed with exit code 1.

I have no idea how to fix this. I wonder if as well as pinning black we also only run black on ubuntu? (Formatting doesn't technically need to be run on multiple OS's right?)

@marcharper
Copy link
Member Author

I have no idea how to fix this. I wonder if as well as pinning black we also only run black on ubuntu? (Formatting doesn't technically need to be run on multiple OS's right?)

sgtm

run black on ubuntu only, change order of some tests
@drvinceknight
Copy link
Member

Looks good to me @marcharper, thanks for doing this.

@marcharper marcharper merged commit c27ad09 into dev Mar 30, 2023
@marcharper marcharper deleted the pin-black branch April 29, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants