Do not include legend box if there is no legend #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Whole new root finding - from thiserror to anyhow - Connect with Zenodo
- Broyden's method
|
Hello @GComitini , Thank you for your interest in the Peroxide project and for taking the time to submit this pull request. I appreciate your valuable contribution in fixing the empty legend box issue for Plot2D. I have reviewed your changes, and they look great. The code effectively addresses the problem and will improve the user experience. I have merged your pull request into the dev branch, and it will be included in the upcoming Peroxide release. Once again, thank you for your contribution. We value the support and involvement of the community in making Peroxide better. Best regards, |
Axect
added a commit
that referenced
this pull request
Apr 16, 2024
- Do not include legend box if there is no legend (#58) - Add rtol for Broyden method - High-level macros for root finding
Axect
added a commit
that referenced
this pull request
Apr 16, 2024
- Do not include legend box if there is no legend (#58) - Add rtol for Broyden method - High-level macros for root finding
|
Hello, I published new version - |
|
Hello, thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
Plot2Dis created and no legend is set, the plot still includes an empty legend box in the form of a small empty square placed at some corner of the image. This PR fixes this behavior, only drawing the legend if thelegendvector is not empty.