-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blas linkage #54
Comments
Reading Cargo book and it seems like convention dictates From this, I would conclude that Peroxide should definitely not include any linkage in |
@gfaster Thank you for great feedback! Thank you again for reporting this issue. I'll fix this problem and publish new version soon 🚀 |
I've released Ver 0.33.0 with your feedback and updated the BLAS description in the README accordingly. You should now be able to use the BLAS backend of your choice. |
As it stands now, Peroxide enforces use of OpenBLAS even though all the libraries and apis it uses are agnostic to the BLAS library variant. In order to use a different BLAS implementation, one must delete Peroxide's
build.rs
, everything works fine otherwise. Especially as this tutorial page is linked in the README, I think it should be expected that the user should be the one to include the linkage lines in theirbuild.rs
.Realistically, I think there are a few good ways of changing this:
build.rs
and leave it to the user to include the right libraries (I believe this is the best course of action)build.rs
openblas
toblas
- many distros/package managers will havelibblas
symlinked to the installed BLAS implementation, OpenBLAS included.links
tag to Cargo.toml to allow for explicit overridingRegardless, Peroxide explicitly linking to OpenBLAS is undesirable due to the plethora of other BLAS implementations (including open source ones like ClBlast) that can be used with no source code changes.
The text was updated successfully, but these errors were encountered: