-
Notifications
You must be signed in to change notification settings - Fork 85
Feature/canopee #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/canopee #1572
Conversation
db639fc to
35b555c
Compare
GuillaumeKESTEMAN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudrait mettre à jour dans les mdx du storybook afin d'utiliser comme imports@axa-fr/canopee-react.
Peut-être plus une PR dédiée vu que celle-ci est déjà bien remplie ?
| "src/**/types.d.ts", | ||
| "src/env.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "src/**/types.d.ts", | |
| "src/env.d.ts", | |
| "src/**/*.d.ts", |
935d4c1 to
848ce4b
Compare
|
Est-ce qu'on modifie dans cette PR le README pour dire d'utiliser Canopée et non |
848ce4b to
6fe8975
Compare
4a77227 to
9f622c5
Compare
pplancq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je bloque le temps que je remettre en place la ci de publish
|
johnmeunier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'approuve même si j'avoue nas pas avoir regardé dans le détail les 915 fichier / et quasi 30k lignes de changement
pplancq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est étrange mais je ne vois pas de fille remove dans slash-react comme dans apollo-react
| release: | ||
| tag: RC | ||
| regex: ^releases?-client[/-](?<BranchName>.+) | ||
| regex: ^releases[/-](?<BranchName>.+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| regex: ^releases[/-](?<BranchName>.+) | |
| regex: ^release[/-](?<BranchName>.+) |
|
|
||
| ### <abbr title="Business to business">B2B</abbr> - Univers Collab-Distrib | ||
|
|
||
| [](https://www.npmjs.com/@axa-fr/design-system-slash-react) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [](https://www.npmjs.com/@axa-fr/design-system-slash-react) | |
| [](https://www.npmjs.com/@axa-fr/canopee-react) |
C'est pas bloquant mais il faudra mettre à jours toute les lien vers NPM et du coup voir pour les regrouper
|
|
||
| ```bash | ||
| git tag slash/1.0.0-RC.1 | ||
| git tag v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| git tag v1.0.0 | |
| git tag v1.0.0-RC.1 |
| git tag v1.0.0 | ||
| ``` | ||
|
|
||
| The prefix is important because it is used to know which design system has to be released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cette ligne n'est plus utile car plus de prefix slash ou client
| @@ -1,33 +1,33 @@ | |||
| /* eslint-disable import/no-extraneous-dependencies */ | |||
| import { loadEnv } from "vite"; | |||
| import { defineConfig } from "vitest/config"; | |||
| import { loadEnv } from 'vite'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est étrange que le formatage remplace les double quote par de simple car notre config de prettier sur le projet impose les double quote
| branches: | ||
| - "releases-slash/*" | ||
| - "releases-client/*" | ||
| - "release/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il faudrait retirer ce déclencher afin de déclenche qu'au tag et sur main
| }, | ||
| "./dist/*": "./dist/*" | ||
| "./*.svg": "./files/assets/*.svg", | ||
| "./dist/common/assets/logo-axa.svg": "./files/assets/logo-axa.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
celle ligne n'été, pas présente sur apollo donc pas besoin de la mettre ici



Todo