Skip to content

Conversation

@samuel-gomez-axa
Copy link
Contributor

@samuel-gomez-axa samuel-gomez-axa commented Nov 18, 2025

Todo

  • faire une version 3.0 de Slash (bye bye Sass)
  • faire une version last version de Look&feel et la flaguée en deprecated sur npm
  • finaliser la CI de publication Canopée
  • mettre une doc de migration + prompt
  • faire une 4.0 des Apollo/Slash et 1.0 de Canopée

Copy link
Contributor

@GuillaumeKESTEMAN GuillaumeKESTEMAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait mettre à jour dans les mdx du storybook afin d'utiliser comme imports@axa-fr/canopee-react.
Peut-être plus une PR dédiée vu que celle-ci est déjà bien remplie ?

Comment on lines +30 to +31
"src/**/types.d.ts",
"src/env.d.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"src/**/types.d.ts",
"src/env.d.ts",
"src/**/*.d.ts",

@pplancq pplancq force-pushed the feature/canopee branch 3 times, most recently from 935d4c1 to 848ce4b Compare November 20, 2025 09:14
@GuillaumeKESTEMAN
Copy link
Contributor

GuillaumeKESTEMAN commented Nov 24, 2025

Est-ce qu'on modifie dans cette PR le README pour dire d'utiliser Canopée et non @axa-fr/design-system-... ?

Copy link
Contributor

@pplancq pplancq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je bloque le temps que je remettre en place la ci de publish

@sonarqubecloud
Copy link

@samuel-gomez-axa samuel-gomez-axa marked this pull request as ready for review November 25, 2025 08:39
Copy link
Contributor

@johnmeunier johnmeunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'approuve même si j'avoue nas pas avoir regardé dans le détail les 915 fichier / et quasi 30k lignes de changement

Copy link
Contributor

@pplancq pplancq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est étrange mais je ne vois pas de fille remove dans slash-react comme dans apollo-react

release:
tag: RC
regex: ^releases?-client[/-](?<BranchName>.+)
regex: ^releases[/-](?<BranchName>.+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regex: ^releases[/-](?<BranchName>.+)
regex: ^release[/-](?<BranchName>.+)


### <abbr title="Business to business">B2B</abbr> - Univers Collab-Distrib

[![NPM Version (with dist tag)](https://img.shields.io/npm/v/%40axa-fr%2Fdesign-system-slash-react/latest?label=slash-react&link=https%3A%2F%2Fwww.npmjs.com%2F%40axa-fr%2Fdesign-system-slash-react)](https://www.npmjs.com/@axa-fr/design-system-slash-react)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![NPM Version (with dist tag)](https://img.shields.io/npm/v/%40axa-fr%2Fdesign-system-slash-react/latest?label=slash-react&link=https%3A%2F%2Fwww.npmjs.com%2F%40axa-fr%2Fdesign-system-slash-react)](https://www.npmjs.com/@axa-fr/design-system-slash-react)
[![NPM Version (with dist tag)](https://img.shields.io/npm/v/%40axa-fr%2Fcanopee-react/latest?label=canopee-react&link=https%3A%2F%2Fwww.npmjs.com%2F%40axa-fr%2Fcanopee-react)](https://www.npmjs.com/@axa-fr/canopee-react)

C'est pas bloquant mais il faudra mettre à jours toute les lien vers NPM et du coup voir pour les regrouper


```bash
git tag slash/1.0.0-RC.1
git tag v1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git tag v1.0.0
git tag v1.0.0-RC.1

git tag v1.0.0
```

The prefix is important because it is used to know which design system has to be released.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cette ligne n'est plus utile car plus de prefix slash ou client

@@ -1,33 +1,33 @@
/* eslint-disable import/no-extraneous-dependencies */
import { loadEnv } from "vite";
import { defineConfig } from "vitest/config";
import { loadEnv } from 'vite';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est étrange que le formatage remplace les double quote par de simple car notre config de prettier sur le projet impose les double quote

branches:
- "releases-slash/*"
- "releases-client/*"
- "release/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il faudrait retirer ce déclencher afin de déclenche qu'au tag et sur main

},
"./dist/*": "./dist/*"
"./*.svg": "./files/assets/*.svg",
"./dist/common/assets/logo-axa.svg": "./files/assets/logo-axa.svg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

celle ligne n'été, pas présente sur apollo donc pas besoin de la mettre ici

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants