feat(slash): add test for table component #1395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pplancq
reviewed
Aug 13, 2025
Contributor
pplancq
left a comment
pplancq
left a comment
There was a problem hiding this comment.
Il faudrait que les tests et exemple soit en anglais
| </Table>, | ||
| ); | ||
|
|
||
| const table = container.querySelector("table"); |
Contributor
There was a problem hiding this comment.
getByRole('table') normalement c'est bon
| describe("Composants de la table", () => { | ||
| it("devrait rendre un tableau avec la classe correcte", () => { | ||
| const { container } = render( | ||
| <Table data-testid="table"> |
Contributor
There was a problem hiding this comment.
pourquoi mettre un data-testid s'il n'est pas utiliser dans le test
| }); | ||
|
|
||
| it("devrait accepter et appliquer une classe custom", () => { | ||
| const { container } = render(<Table className="custom-class">{}</Table>); |
Contributor
There was a problem hiding this comment.
Suggested change
| const { container } = render(<Table className="custom-class">{}</Table>); | |
| const { container } = render(<Table className="custom-class"/>); |
Comment on lines
+41
to
+42
| expect(table?.className).toContain("af-table"); | ||
| expect(table?.className).toContain("mod"); |
Contributor
There was a problem hiding this comment.
Suggested change
| expect(table?.className).toContain("af-table"); | |
| expect(table?.className).toContain("mod"); | |
| expect(table).toHaveClass("af-table af-table--mod"); |
| </Table.THead>, | ||
| ); | ||
|
|
||
| const thead = container.querySelector("thead"); |
Contributor
There was a problem hiding this comment.
il me semble que getByRole('rowgroup') devrait fonctionner.
| <Table.Td data-test-id="td-test" aria-label="label" />, | ||
| ); | ||
|
|
||
| const td = container.querySelector("td"); |
Contributor
There was a problem hiding this comment.
il me semble que getByRole('cell') devrait fonctionner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat #698
The Slash Table component has no test, so his coverage is at 0%
The component should be covered.
https://sonarcloud.io/component_measures?metric=coverage&selected=AxaFrance_design-system%3Aslash%2Freact%2Fsrc%2FTable&id=AxaFrance_design-system
Close #698