Styles applying order

[Axavo]

Styles applied to an element not in the order they are declared in xaml, or the complexity of their selectors. In exаmple "Maximize" button have to be hidden, but it is not.
AvaloniaApplication1.zip

[kekekeks]

The last CustomWindow-related selector in Theme.xaml

  <Style Selector="l|CustomWindow[CanResize=false] /template/ Button#PART_MaximizeButton">
    <Setter Property="IsVisible" Value="False" />
  </Style>

should hide the maximize button, when CanResize=False, but it doesn't

[grokys]

You seem to be setting IsVisible = true as a local value in the template in Theme.xaml:

<Button x:Name="PART_MaximizeButton"
        IsVisible="True"
        Classes="WindowTitleButton">
  <TextBlock Text="Max"/>
</Button>

Local values have a higher priority than styles, so it will always be true.

[grokys]

By the way, this is the same behavior as WPF/UWP.

We would like to improve the experience here, by setting properties in control templates with Style priority, but we've been unable to do that with Portable.Xaml. Now we have our own XAML compiler we hope to improve this in future.

[Axavo]

The workaround is to remove the property from the template and add it to another style?

[grokys]

In this case you just need to remove IsVisible="True" from the Button, as true is the default value.

In general, yes, you should add the default value to a style so it can be overridden, e.g.

https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Themes.Default/ListBoxItem.xaml#L26-L28

[kekekeks]

#2789