Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues about Material.Dialog submodule #156

Open
appleneko2001 opened this issue Feb 11, 2022 · 3 comments
Open

Issues about Material.Dialog submodule #156

appleneko2001 opened this issue Feb 11, 2022 · 3 comments
Assignees
@appleneko2001
Labels
api break Possibly breaks old API after fix. bug Something isn't working

Comments

@appleneko2001
Copy link
Collaborator

In these days I reviewed my Material.Dialog library and I found a lot problem on implementations and coding-style. So I want to remaster those things I created, because fix them is barely possible, but could takes a long time and possibly to break features again. But dont worry! I will take care to not break API. So you guys can keep source code without changes.

Related issues: #152
@appleneko2001 appleneko2001 added bug Something isn't working api break Possibly breaks old API after fix. labels Feb 11, 2022
@appleneko2001 appleneko2001 self-assigned this Feb 11, 2022
@appleneko2001 appleneko2001 pinned this issue Feb 11, 2022
@appleneko2001
Copy link
Collaborator Author

Do not use nightly-package version 2.5.0.74-nightly or above.
CustomDialog, Time and date picker dialog and text field dialog will unavailable until I remaster them.

@appleneko2001
Copy link
Collaborator Author

TextFieldDialog should be usable now.
version: 2.5.0.76-nightly or above.
commit: de36bce

@appleneko2001
Copy link
Collaborator Author

CustomDialog is shipped with 2.5.0.75-nightly but untested. Unfortunately I dont have time to test this feature. Thanks sabuto that he accepted my request and give me result of usability CustomDialog

For now we only need to remaster DatePicker and TimePicker and this issue could be closed after 3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleneko2001 appleneko2001

Labels
api break Possibly breaks old API after fix. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appleneko2001