Merge pull request #12 from Automattic/update/escape-hash-values-when-exporting

Fix sqlite export by escaping strings with numbers and e character

Author: sejas

features/bootstrap/SQLiteFeatureContext.php

@@ -166,4 +166,30 @@ public function theFileShouldNotContain( $filename, PyStringNode $content ) {
 			throw new Exception( "File contains unexpected content:\n" . $content );
 		}
 	}
+
+	/**
+	 * @Given /^the SQLite database contains a test table with alphanumeric string hash values$/
+	 */
+	public function theSqliteDatabaseContainsATestTableWithAlphanumericStringHashValues() {
+		$this->connectToDatabase();
+
+		// Create a test table with hash values that look like scientific notation
+		$this->db->exec( 'DROP TABLE IF EXISTS test_export_alphanumeric_string' );
+		$this->db->exec(
+			'
+			CREATE TABLE test_export_alphanumeric_string (
+				id INTEGER PRIMARY KEY,
+				hash_value TEXT
+			)
+		'
+		);
+
+		// Insert test data with values that might be mistaken for scientific notation
+		$this->db->exec(
+			"
+			INSERT INTO test_export_alphanumeric_string (id, hash_value) VALUES
+			(1, '123e99')
+		"
+		);
+	}
 }

features/sqlite-export.feature

@@ -115,3 +115,21 @@ Feature: WP-CLI SQLite Export Command
       """
       CREATE TABLE `wp_users`
       """
+
+  @require-sqlite
+  Scenario: Export should escape alphanumeric strings with e character
+    Given the SQLite database contains a test table with alphanumeric string hash values
+    When I run `wp sqlite export test_export_alphanumeric_string.sql --tables=test_export_alphanumeric_string`
+    Then STDOUT should contain:
+      """
+      Success: Export complete. File written to test_export_alphanumeric_string.sql
+      """
+    And the file "test_export_alphanumeric_string.sql" should exist
+    And the file "test_export_alphanumeric_string.sql" should contain:
+      """
+      INSERT INTO `test_export_alphanumeric_string` VALUES (1,'123e99');
+      """
+    But the file "test_export_alphanumeric_string.sql" should not contain:
+      """
+      INSERT INTO `test_export_alphanumeric_string` VALUES (1,123e99);
+      """

src/Export.php

@@ -239,7 +239,7 @@ protected function escape_values( PDO $pdo, $values ) {
 		foreach ( $values as $value ) {
 			if ( is_null( $value ) ) {
 				$escaped_values[] = 'NULL';
-			} elseif ( is_numeric( $value ) ) {
+			} elseif ( ctype_digit( $value ) ) {
 				$escaped_values[] = $value;
 			} else {
 				// Quote the values and escape encode the newlines so the insert statement appears on a single line.