Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Display Email Forwards as a List #94795

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Sep 21, 2024

edit: this needs a fix to ensure the HTML layout is acceptable!

Proposed Changes

Ensures that the Email Forwarding list is displayed as a list.

Why are these changes being made?

At the moment, the items aren't visible when there's more than a few. It also doesn't seem appropriate to use a paragraph tag here, which is what currently happens.

Testing Instructions

  • Navigate to My Sites > Upgrades > Domains
  • Add some email forwards
  • Confirm that the list now appears properly
Before After
Screenshot 2024-09-21 at 15 53 37 Screenshot 2024-09-21 at 15 53 01

cc @rafaelgallani, @gius80, @leonardost

@Aurorum Aurorum requested a review from a team as a code owner September 21, 2024 14:57
@Aurorum Aurorum marked this pull request as draft September 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant