Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Improve Loading State for Highlight Cards #85689

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Dec 22, 2023

Fixes #85446 - also just something I stumbled into and thought could do with improving

Proposed Changes

  • Improves the loading state for the Highlight Cards in the Stats section to make it more clear that the Stats will load. The original issue suggested using Spinners, but I felt that four spinners seemed a bit...much. Also, Calypso seems to use the placeholder animation for text, so I thought it'd be more fitting here.

Testing Instructions

You might need to throttle your connection under the "Network" tab to slow down the amount of time it takes for Stats to appear. However, you should see this under the /stats section.

Before:
291433784-d1483890-0259-4ef7-b462-617901d2f255 (1)

After: (it's an animation!)
Screenshot 2023-12-22 at 10 36 13

cc @jsnmoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: Make loading state for each highlight card more obvious
1 participant