Skip to content

Domains: Mobile improvements - Leftovers #53768

Open

Description

What

See gnYBUOBthTMckJRJr3pZmk-fi-2598%3A1 for more details.

  1. Margin above the search input should be 24px. (see Domains: Mobile improvements - Leftovers #53768 (comment))
  2. The loading state leaks to all select buttons when one is clicked (see this video).
  3. [MOBILE] The suggestions "table" margin-left & margin-right should be 20px (the same as the title & subtitle).
  4. @media (min-width: 480px): Remove margin-left (see screenshot).

Acceptance criteria

  • The suggestion table margin-left is 20px on mobile viewports.
  • The suggestion table margin-right is 20px on mobile viewports.
  • Visible loading state is removed from the other select buttons when a button is clicked.
  • disabled state is applied to other select buttons when a button is clicked ("invisible" disabled state (c) Razvan)
  • disabled buttons look unchanged (styles are overridden)

Screen Shot 2021-06-17 at 4 02 50 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions