Skip to content

Conversation

@notandyvee
Copy link
Contributor

Fix

We have a requirement where during the new login flow, if the user decides to login with password we will hide the email field. In it's place we show some text indicating what the email is.

Doing this required some simperium changes. But it's a pain to get this to work. Instead I opted to copy over the activity and converted it into kotlin. I also removed SimpleNoteCredentialsActivity and just took the logic from there and added it to the NewCredentialsActivity.

The goal here is to move the business logic into a ViewModel and also extract the code out into a fragment. But to keep the changes to a minimum considering the kotlin conversion, I will save that work for later.

Screenshot_20240730_183638

Test

  • Select Login
  • Enter your email and click "Log in with email"
  • On the next screen select "Enter password".
  • On this screen you should see some text at the top with the email to login with and a password field.
  • Make sure logging in by password still works here.

Release

n/a

@notandyvee notandyvee added the task This issue is some sort of task or a spike of time not directly related to a feature. label Jul 30, 2024
@notandyvee notandyvee requested review from danilo04 and roundhill July 30, 2024 22:51
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 30, 2024

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commitbdfc9b9
Direct Downloadsimplenote-android-prototype-build-pr1671-bdfc9b9-01914d95-4545-451a-b5b3-62f2f92323f2.apk

@notandyvee
Copy link
Contributor Author

@danilo04 bumping you for a quick review when you get a chance.

@danilo04 danilo04 self-assigned this Aug 14, 2024
Copy link
Contributor

@danilo04 danilo04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @notandyvee, everything is working as expected. Good job :shipit:

@danilo04 danilo04 merged commit e860c48 into trunk Aug 14, 2024
@danilo04 danilo04 deleted the andy/firebird-issue-92 branch August 14, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task This issue is some sort of task or a spike of time not directly related to a feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants