[Auth] Copied over CredentialsActivity from Simperium to customize login screen. #1671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
We have a requirement where during the new login flow, if the user decides to login with password we will hide the email field. In it's place we show some text indicating what the email is.
Doing this required some simperium changes. But it's a pain to get this to work. Instead I opted to copy over the activity and converted it into kotlin. I also removed
SimpleNoteCredentialsActivityand just took the logic from there and added it to theNewCredentialsActivity.The goal here is to move the business logic into a
ViewModeland also extract the code out into a fragment. But to keep the changes to a minimum considering the kotlin conversion, I will save that work for later.Test
Release
n/a