Moving all SVN specific calls to the PHPCS_Diff_SVN_parser class

Author: david-binda

class-phpcs-diff-svn-parser.php

@@ -157,4 +157,19 @@ public static function parse_diff_for_info( $diff_file ){
 
 	}
 
+	public function run_phpcs_for_file_at_revision( $filename, $revision, $phpcs_command, $standards_location, $phpcs_standard ) {
+		$command_string	= sprintf( 'svn cat %s --non-interactive --no-auth-cache --username %s --password %s -r %d | %s --runtime-set installed_paths %s --standard=%s --stdin-path=%s',
+			escapeshellarg( esc_url_raw( $this->repo_url . $filename ) ),
+			escapeshellarg( $this->svn_username ),
+			escapeshellarg( $this->svn_password ),
+			absint( $revision ),
+			escapeshellcmd( $phpcs_command ),
+			escapeshellarg( $standards_location ),
+			escapeshellarg( $phpcs_standard ),
+			escapeshellarg( $filename )
+		);
+
+		return shell_exec( $command_string );
+	}
+
 }

class-phpcs-diff.php

@@ -2,10 +2,6 @@
 
 class PHPCS_Diff {
 
-	// SVN credentials used for checking out individual revisions.
-	private $svn_username = ''; // @todo: add your SVN username here
-	private $svn_password = ''; // @todo: add your SVN password here
-
 	// PHPCS configuration.
 	private $phpcs_command = 'phpcs'; // You might need to provde a path to phpcs.phar file.
 	private $standards_location = '~/PHP_CodeSniffer/Standards'; // @todo: adjust the path to standards
@@ -16,8 +12,6 @@ class PHPCS_Diff {
 
 	public $excluded_extensions = array();
 
-	public $repo_url = 'https://plugins.svn.wordpress.org/';
-
 	public $lines_mapping;
 
 	private $phpcs_standard = 'WordPress';
@@ -162,18 +156,8 @@ private function run_phpcs_for_file_revision( $filename, $revision ) {
 
 		if ( false === $result ) {
 
-			$command_string		= sprintf( 'svn cat %s --non-interactive --no-auth-cache --username %s --password %s -r %d | %s --runtime-set installed_paths %s --standard=%s --stdin-path=%s',
-				escapeshellarg( esc_url_raw( $this->repo_url . $filename ) ),
-				escapeshellarg( $this->svn_username ),
-				escapeshellarg( $this->svn_password ),
-				absint( $revision ),
-				escapeshellcmd( $this->phpcs_command ),
-				escapeshellarg( $this->standards_location ),
-				escapeshellarg( $this->phpcs_standard ),
-				escapeshellarg( $filename )
-			);
-
-			$result = shell_exec( $command_string );
+			$result = $this->diff_parser->run_phpcs_for_file_at_revision( $filename, $revision, $this->phpcs_command, $this->standards_location, $this->phpcs_standard );
+
 			if ( true !== $this->nocache ) {
 				wp_cache_set( $cache_key, $result, $cache_group, 6*HOUR_IN_SECONDS );
 			}