Add packages to the uninstall list

Author: jamesbvaughan

.github/workflows/prebuild.yaml

@@ -46,6 +46,79 @@ on: workflow_dispatch
 # Manually set this file depending on what you're building!!
 
 jobs:
+  Linux:
+    strategy:
+      matrix:
+        node: [18.12.0, 20.9.0]
+        canvas_tag: [] # e.g. "v2.6.1"
+    name: ${{ matrix.canvas_tag}}, Node.js ${{ matrix.node }}, Linux
+    runs-on: ubuntu-latest
+    container:
+      image: chearon/canvas-prebuilt:7
+    env:
+      CANVAS_VERSION_TO_BUILD: ${{ matrix.canvas_tag }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ matrix.canvas_tag }}
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: Build
+        run: |
+          npm install -g node-gyp
+          npm install --ignore-scripts
+          . prebuild/Linux/preinstall.sh
+          cp prebuild/Linux/binding.gyp binding.gyp
+          node-gyp rebuild -j 2
+          . prebuild/Linux/bundle.sh
+
+      - name: Test binary
+        run: |
+          cd /root/harfbuzz-* && make uninstall
+          cd /root/cairo-* && make uninstall
+          cd /root/pango-* && make uninstall
+          cd /root/libpng-* && make uninstall
+          cd /root/libjpeg-* && make uninstall
+          cd /root/giflib-* && make uninstall
+          cd $GITHUB_WORKSPACE && npm test
+
+      - name: Make bundle
+        id: make_bundle
+        run: . prebuild/tarball.sh
+
+      - name: Upload
+        uses: actions/github-script@0.9.0
+        with:
+          script: |
+            const fs = require("fs");
+            const assetName = "${{ steps.make_bundle.outputs.asset_name }}";
+            const tagName = process.env.UPLOAD_TO || process.env.CANVAS_VERSION_TO_BUILD;
+            const [owner, repo] = process.env.GITHUB_REPOSITORY.split("/");
+
+            const releases = await github.repos.listReleases({owner, repo});
+            const release = releases.data.find(r => r.tag_name === tagName);
+            if (!release)
+              throw new Error(`Tag ${tagName} not found. Did you make the GitHub release?`);
+
+            const oldAsset = release.assets.find(a => a.name === assetName);
+            if (oldAsset)
+              await github.repos.deleteReleaseAsset({owner, repo, asset_id: oldAsset.id});
+
+            // (This is equivalent to actions/upload-release-asset. We're
+            // already in a script, so might as well do it here.)
+            const r = await github.repos.uploadReleaseAsset({
+              url: release.upload_url,
+              headers: {
+                "content-type": "application/x-gzip",
+                "content-length": `${fs.statSync(assetName).size}`
+              },
+              name: assetName,
+              data: fs.readFileSync(assetName)
+            });
+
   macOS:
     strategy:
       fail-fast: false
@@ -88,7 +161,7 @@ jobs:
 
       - name: Test binary
         run: |
-          brew uninstall --force --ignore-dependencies cairo pango librsvg giflib harfbuzz
+          brew uninstall --force --ignore-dependencies cairo pango jpeg libpng librsvg giflib pixman harfbuzz
           npm test
 
       - name: Make bundle
@@ -124,3 +197,78 @@ jobs:
               name: assetName,
               data: fs.readFileSync(assetName)
             });
+
+  Win:
+    strategy:
+      matrix:
+        node: [18.12.0, 20.9.0]
+        canvas_tag: [] # e.g. "v2.6.1"
+    name: ${{ matrix.canvas_tag}}, Node.js ${{ matrix.node }}, Windows
+    runs-on: windows-latest
+    env:
+      CANVAS_VERSION_TO_BUILD: ${{ matrix.canvas_tag }}
+    steps:
+      # TODO drop when https://github.com/actions/virtual-environments/pull/632 lands
+      - uses: numworks/setup-msys2@v1
+        with:
+          update: true
+          path-type: inherit
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
+
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ matrix.canvas_tag }}
+
+      - name: Build
+        run: |
+          npm install -g node-gyp
+          npm install --ignore-scripts
+          msys2do . prebuild/Windows/preinstall.sh
+          msys2do cp prebuild/Windows/binding.gyp binding.gyp
+          msys2do node-gyp configure
+          msys2do node-gyp rebuild -j 2
+
+      - name: Bundle
+        run: msys2do . prebuild/Windows/bundle.sh
+
+      - name: Test binary
+        # By not running in msys2, this doesn't have access to the msys2 libs
+        run: npm test
+
+      - name: Make asset
+        id: make_bundle
+        # I can't figure out why this isn't an env var already. It shows up with `env`.
+        run: msys2do UPLOAD_TO=${{ env.UPLOAD_TO }} CANVAS_VERSION_TO_BUILD=${{ env.CANVAS_VERSION_TO_BUILD}} . prebuild/tarball.sh
+
+      - name: Upload
+        uses: actions/github-script@0.9.0
+        with:
+          script: |
+            const fs = require("fs");
+            const assetName = "${{ steps.make_bundle.outputs.asset_name }}";
+            const tagName = process.env.UPLOAD_TO || process.env.CANVAS_VERSION_TO_BUILD;
+            const [owner, repo] = process.env.GITHUB_REPOSITORY.split("/");
+
+            const releases = await github.repos.listReleases({owner, repo});
+            const release = releases.data.find(r => r.tag_name === tagName);
+            if (!release)
+              throw new Error(`Tag ${tagName} not found. Did you make the GitHub release?`);
+
+            const oldAsset = release.assets.find(a => a.name === assetName);
+            if (oldAsset)
+              await github.repos.deleteReleaseAsset({owner, repo, asset_id: oldAsset.id});
+
+            // (This is equivalent to actions/upload-release-asset. We're
+            // already in a script, so might as well do it here.)
+            const r = await github.repos.uploadReleaseAsset({
+              url: release.upload_url,
+              headers: {
+                "content-type": "application/x-gzip",
+                "content-length": `${fs.statSync(assetName).size}`
+              },
+              name: assetName,
+              data: fs.readFileSync(assetName)
+            });

prebuild/tarball.sh

@@ -6,14 +6,14 @@ FILENAME=$(
     const tagName = p.env.UPLOAD_TO || p.env.CANVAS_VERSION_TO_BUILD;
     console.log('canvas-' + tagName + '-napi-v7-' + p.platform + libc + '-' + p.arch);
   "
-).tar.gz;
+).tar.gz
 
 # Zip up the release
 tar -czvf $FILENAME build
 
 if [ $? -ne 0 ]; then
   echo "failed to make tarball $FILENAME from node-canvas/build"
-  exit 1;
+  exit 1
 else
   echo "::set-output name=asset_name::$FILENAME"
 fi